WIP: Remove conda files #1561
Merged
WIP: Remove conda files #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7657069746
💛 - Coveralls |
…o remove_conda_files
lrzpellegrini
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Removing conda env files makes sense as it's currently becoming harder to support an environment with both conda and pip dependencies.
I left a couple of comments to check.
PS: I think we can safely remove the constraint on typing_extensions in requirements.txt, too.
PS 2: after further investigation, it seems that versions of typing-extensions <4.6.0 do not work well with dill. It seems reasonable to add a >=4.6.0 constraint.
| @@ -21,6 +21,9 @@ on: | |||
| paths: | |||
| - 'docker/nightly/**' | |||
| - '.github/workflows/docker-nightly-release.yml' | |||
| - 'requirements.txt' | |||
| - 'setup.py' | |||
| - 'extra_dependencies.py' | |||
There was a problem hiding this comment.
I think it's extra_dependencies.txt
| @@ -17,6 +17,9 @@ on: | |||
| - master | |||
| paths: | |||
| - '.github/workflows/environment-update.yml' | |||
| - 'requirements.txt' | |||
| - 'setup.py' | |||
| - 'extra_dependencies.py' | |||
There was a problem hiding this comment.
I think it's extra_dependencies.txt
| @@ -26,6 +26,8 @@ on: | |||
| paths: | |||
| - '**.py' | |||
| - '.github/workflows/unit-test.yml' | |||
| - 'requirements.txt' | |||
| - 'extra_dependencies.py' | |||
There was a problem hiding this comment.
I think it's extra_dependencies.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.