Add support GraphlQL Ruby 2.0, Field extensions, Rails 7, and Ruby 3 #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features/1.10 ready
Previously the `field.preload_scope` returned nil when using the field extensions, since field instruments are deprecated. This commit fixes that by checking for the preload scope in the options hash passed to the extension object.
Fixes/handle scope
Add support for Field Extensions
|
@thiagofelix I know you mentioned previously on #32 that it was a big change. Can we do a version bump and release this? Otherwise, this gem can't be used at all with GraphQL 2.0 or the latest Ruby/Rails. It's been quite a few years since this gem's seen an update, I'd be more than happy to take over the project, or even collaborate with @Envek if they are still interested in taking over as well! |
|
@joeyparis - I would love to see this get merged or ported to a new gem. |
andrewjtait
added a commit
to krystal/graphql-preload
that referenced
this pull request
May 23, 2023
Remove old CI stuff and add new stuff to support releasing a gem. I disabled tests that ensure it works with GraphQL v2, as the tests currently fail. If we want to support v2 then we should look into this fork: ConsultingMD#38
andrewjtait
added a commit
to krystal/graphql-preload
that referenced
this pull request
May 23, 2023
Remove old CI stuff and add new stuff to support releasing a gem. I disabled tests that ensure it works with GraphQL v2, as the tests currently fail. If we want to support v2 then we should look into this fork: ConsultingMD#38
andrewjtait
added a commit
to krystal/graphql-preload
that referenced
this pull request
May 23, 2023
Remove old CI stuff and add new stuff to support releasing a gem. I disabled tests that ensure it works with GraphQL v2, as the tests currently fail. If we want to support v2 then we should look into this fork: ConsultingMD#38
andrewjtait
added a commit
to krystal/graphql-preload
that referenced
this pull request
May 23, 2023
Remove old CI stuff and add new stuff to support releasing a gem. I disabled tests that ensure it works with GraphQL v2, as the tests currently fail. If we want to support v2 then we should look into this fork: ConsultingMD#38
andrewjtait
added a commit
to krystal/graphql-preload
that referenced
this pull request
May 23, 2023
Remove old CI stuff and add new stuff to support releasing a gem. I disabled tests that ensure it works with GraphQL v2, as the tests currently fail. If we want to support v2 then we should look into this fork: ConsultingMD#38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
graphql-ruby2.0, Field extensions, Rails 7, and Ruby 3. Also adds a series of tests written by rkorzeniec.