Skip to content

Conversation

@rudokemper
Copy link
Member

Goal

Resolve a few minor issues on the User Management page

Screenshots

image

Return to Homepage button

image

localized UserEditModal

What I changed and why

  • Added a "Return to Homepage" button, since there is no way to go back in the UI. I think eventually we will want to add the same header design as the homepage itself, so this is a stopgap implementation for now.
  • I noticed the mouse pointer wasn't changing when hovering over links & buttons, so I fixed that.
  • I added translations for UserEditModal.

What I'm not doing here

So most of this code isn't Prettier-compatible, and my IDE applies Prettier auto-formatting. I didn't bother cherry picking my changes, so a lot of this PR is just reformatting.

I think after this PR and #35 is merged, we should run pnpm run lint:prettier --write and add a .git-blame-ignore-revs file to ignore the reformat commit in git blame. And we should all either use auto formatting in our IDE or always run pnpm run lint:prettier --write before committing anything.

LLM use disclosure

I supervised Cursor to make these changes.

@rudokemper rudokemper added this to the Nia Tero 2025 milestone Nov 12, 2025
@rudokemper rudokemper self-assigned this Nov 12, 2025
@conservationtimothy
Copy link
Contributor

we should run pnpm run lint:prettier --write and add a .git-blame-ignore-revs file to ignore the reformat commit in git blame. And we should all either use auto formatting in our IDE or always run pnpm run lint:prettier --write before committing anything.

We can probably go a git commit hook but writing this I think we've had a long discussion about this somewhere i.e. in CI versus git hooks

@rudokemper
Copy link
Member Author

Yeah, the Nuxt repos actually had pre-commit hooks with Husky, but we ripped them out after some discussion and just deciding to leave it to the developer: https://github.com/ConservationMetrics/gc-scripts-hub/blob/main/CONTRIBUTING.md#prettier--eslint-for-javascript-json--scss

@IamJeffG and I both auto-format in our IDEs.

@rudokemper rudokemper merged commit 4b3cbe1 into main Nov 13, 2025
1 check passed
@rudokemper rudokemper deleted the user-management-fixes branch November 13, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants