Skip to content

Optimize string reading with bytes.Buffer #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentdeed wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Optimize string reading with bytes.Buffer #998

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c22ed3
Optimize string reading with bytes.Buffer
sentdeed Jul 11, 2025
3ea1e87
Merge branch 'main' into main
sentdeed Jul 23, 2025
5426014
Merge branch 'main' into main
sentdeed Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions pkg/util/files.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ package util

import (
"bufio"
"bytes"
"compress/bzip2"
"errors"
"io"
Expand Down Expand Up @@ -61,26 +62,20 @@ func ReadInputFile(filename string) []string {

// Read a single line
func readLine(reader *bufio.Reader) *string {
var (
bytes []byte
bit []byte
err error
)
//
var buffer bytes.Buffer
cont := true
//

for cont {
bit, cont, err = reader.ReadLine()
bit, cont, err := reader.ReadLine()
if err == io.EOF {
return nil
} else if err != nil {
panic(err)
}

bytes = append(bytes, bit...)
buffer.Write(bit)
}
// Convert to string
str := string(bytes)
// Done

str := buffer.String()
return &str
}