feat: add sampled mul tests #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
force-pushed
the
1378-feat-enable-koalabear_16-for-assembly-tests
branch
10 times, most recently
from
9fb121e to
3123afd
Compare
This reduces the number of test inputs for the mul benchmark in order that it can complete in some reasonable time
DavePearce
force-pushed
the
1378-feat-enable-koalabear_16-for-assembly-tests
branch
2 times, most recently
from
2156fb0 to
2d84cd0
Compare
This resample the bench tests for euc, exp and wcp. This also tweaks the settings for GOMAXPROCS and GOMEMLIMIT (which appears to help considerably), and also prevents parallel testing on the larger tests (i.e. because go-corset is already doing stuff in parallel for them).
DavePearce
force-pushed
the
1378-feat-enable-koalabear_16-for-assembly-tests
branch
from
2d84cd0 to
a1dbdc5
Compare
DavePearce
deleted the
1378-feat-enable-koalabear_16-for-assembly-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of test inputs for the mul benchmark in order that it can complete in some reasonable time
Note
Tunes CI and test execution by serializing select Go tests, setting Go runtime limits, enabling KOALABEAR_16 asm-bench in the matrix, and removing a default test helper.
.github/workflows/test.yml):KOALABEAR_16forasm-bench(previously excluded).GOMAXPROCS=8,GOMEMLIMIT=16GiBfor test runs.Makefile):asm-bench,asm-util, andcorset-benchwithgo test -p 1to reduce parallelism.pkg/test/util/check_valid.go):Check(...)wrapper in favor ofCheckCorset(...)variants.Written by Cursor Bugbot for commit a1dbdc5. This will update automatically on new commits. Configure here.