Skip to content

fix(kernel-store): move to better-sqlite3 13, which survives teardown on Node 24.20 #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sirtimid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(kernel-store): move to better-sqlite3 13, which survives teardown on Node 24.20 #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/kernel-store/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- **BREAKING:** Bump `better-sqlite3` from `^12.4.1` to `^13.0.3`, which requires Node 22 or later — the same floor this package already declares
- On Node 24.20.0, 12.x aborts the process during teardown: `Statement::~Statement` reaches `RemoveEnvironmentCleanupHook` after the environment is gone, and Node asserts. The tests it kills have already passed, so it surfaces as a worker dying rather than as a failure anyone can read
- Nothing in this package's driver changes. The 13.x major touches none of `prepare`, `run`, `get`, `all`, `iterate`, `pluck`, `transaction`, `exec`, or `close`

### Fixed

- `rollbackSavepoint` discards the enclosing transaction when `ROLLBACK TO` itself fails, instead of leaving the savepoint on its stack and the transaction open ([#1005](https://github.com/MetaMask/ocap-kernel/pull/1005))
Expand Down
2 changes: 1 addition & 1 deletion packages/kernel-store/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"dependencies": {
"@metamask/logger": "workspace:^",
"@sqlite.org/sqlite-wasm": "^3.49.1-build3",
"better-sqlite3": "^12.4.1",
"better-sqlite3": "^13.0.3",
"ses": "^1.14.0"
},
"devDependencies": {
Expand Down
39 changes: 11 additions & 28 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2628,7 +2628,7 @@ __metadata:
"@typescript-eslint/parser": "npm:^8.29.0"
"@typescript-eslint/utils": "npm:^8.29.0"
"@vitest/eslint-plugin": "npm:^1.6.14"
better-sqlite3: "npm:^12.4.1"
better-sqlite3: "npm:^13.0.3"
depcheck: "npm:^1.4.7"
eslint: "npm:^9.23.0"
eslint-config-prettier: "npm:^10.1.1"
Expand Down Expand Up @@ -7282,14 +7282,13 @@ __metadata:
languageName: node
linkType: hard

"better-sqlite3@npm:^12.4.1":
version: 12.4.6
resolution: "better-sqlite3@npm:12.4.6"
"better-sqlite3@npm:^13.0.3":
version: 13.0.3
resolution: "better-sqlite3@npm:13.0.3"
dependencies:
bindings: "npm:^1.5.0"
node-addon-api: "npm:^8.0.0"
node-gyp: "npm:latest"
prebuild-install: "npm:^7.1.1"
checksum: 10/383b1acc7c9f03e0677ab2aad5d3a44b4d36565396b1d10dfa5ebcf7840799afeb180c2b7c9813d7ffd1d5c92e497d5c9c52118fe7c5839987df87370df69943
checksum: 10/035f8fa70784762fd73e1dbeb6f157186abb97705ff759b312cfb0dc1c675fd1c6b5378d2c036758000ce9da1d49bf61689531aa2718a7e32dc272c114a4c71f
languageName: node
linkType: hard

Expand Down Expand Up @@ -7328,15 +7327,6 @@ __metadata:
languageName: node
linkType: hard

"bindings@npm:^1.5.0":
version: 1.5.0
resolution: "bindings@npm:1.5.0"
dependencies:
file-uri-to-path: "npm:1.0.0"
checksum: 10/593d5ae975ffba15fbbb4788fe5abd1e125afbab849ab967ab43691d27d6483751805d98cb92f7ac24a2439a8a8678cd0131c535d5d63de84e383b0ce2786133
languageName: node
linkType: hard

"bl@npm:^4.0.3":
version: 4.1.0
resolution: "bl@npm:4.1.0"
Expand Down Expand Up @@ -9700,13 +9690,6 @@ __metadata:
languageName: node
linkType: hard

"file-uri-to-path@npm:1.0.0":
version: 1.0.0
resolution: "file-uri-to-path@npm:1.0.0"
checksum: 10/b648580bdd893a008c92c7ecc96c3ee57a5e7b6c4c18a9a09b44fb5d36d79146f8e442578bc0e173dc027adf3987e254ba1dfd6e3ec998b7c282873010502144
languageName: node
linkType: hard

"fill-range@npm:^7.1.1":
version: 7.1.1
resolution: "fill-range@npm:7.1.1"
Expand Down Expand Up @@ -12515,12 +12498,12 @@ __metadata:
languageName: node
linkType: hard

"node-addon-api@npm:^8.3.0, node-addon-api@npm:^8.3.1":
version: 8.5.0
resolution: "node-addon-api@npm:8.5.0"
"node-addon-api@npm:^8.0.0, node-addon-api@npm:^8.3.0, node-addon-api@npm:^8.3.1":
version: 8.9.2
resolution: "node-addon-api@npm:8.9.2"
dependencies:
node-gyp: "npm:latest"
checksum: 10/9a893f4f835fbc3908e0070f7bcacf36e37fd06be8008409b104c30df4092a0d9a29927b3a74cdbc1d34338274ba4116d597a41f573e06c29538a1a70d07413f
checksum: 10/5354f9b53631d99a952408112d795f36782fd41c0ac073bd91814805fe931b619c743689d0cedcc310c0ae8392fc9b104b2852d28cce294236407ca57d01743e
languageName: node
linkType: hard

Expand Down Expand Up @@ -13527,7 +13510,7 @@ __metadata:
languageName: node
linkType: hard

"prebuild-install@npm:^7.1.1, prebuild-install@npm:^7.1.3":
"prebuild-install@npm:^7.1.3":
version: 7.1.3
resolution: "prebuild-install@npm:7.1.3"
dependencies:
Expand Down
Loading