This repository was archived by the owner on Mar 11, 2024. It is now read-only.
Remove event.preventDefault call#39
Open
azappella wants to merge 1 commit intoConsenSys-archive:masterfrom
Open
Remove event.preventDefault call#39azappella wants to merge 1 commit intoConsenSys-archive:masterfrom
azappella wants to merge 1 commit intoConsenSys-archive:masterfrom
Conversation
Problem: The onProfileFormSubmit function makes a redundant call to event.preventDefault() - event.preventDefault is already called inside handleFormSubmit (src/user/ui/ProfileForm.js) - event is never passed from the function which causes an error when trying to update the user name Solution: removed the redundant event.preventDefault call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The onProfileFormSubmit function makes a redundant call to event.preventDefault()
Solution: removed the redundant event.preventDefault call