Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the introduction of end-to-end batching on the Connector SDK, (part of the Connector SDK 0.12.0), source connectors can add support to batching by implementing the
ReadN
method. This wasn't a breaking change since the SDK will fallback to the traditionalRead
method as it can be spotted in the logs when starting Conduit.Example:
2025-04-24T19:21:21+00:00 INF source does not support batch reads, falling back to single reads component=plugin connector_id=postgres-to-kafka:postgres-source plugin_name=builtin:postgres plugin_type=source
This pull-request implements
ReadN
while still maintaining support toRead
method for those who wish to use this connector in an older version of Conduit. This is probably not necessary considering Postgres is a builtin connector.To really utilize the advantage of this, it is recommended to run Conduit with the flag that enables a new upcoming architecture via
--preview.pipeline-arch-v2
. More information on this blog post.Note
Still need to:
Read
andNext
leaving onlyReadN
andNextN
Running benchmarks
Inserting 20M records using Benchi using CDC:
Read
: 142824.47 msg/sReadN
: 153107.18 msg/s (previously )This is a 7,2% better on CDC.
Quick checks: