Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use full CCI and STIG identifiers #5606

Merged
merged 13 commits into from
Jul 28, 2020
Merged

Use full CCI and STIG identifiers #5606

merged 13 commits into from
Jul 28, 2020

Conversation

redhatrises
Copy link
Contributor

@redhatrises redhatrises commented Apr 15, 2020 •
edited
Loading

Reduces confusion and scripting efforts around DISA CCI, STIG ID, and CCE short forms where we don't do this for any other references.

@redhatrises redhatrises added this to the 0.1.50 milestone Apr 15, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Used by openshift-ci bot. needs-rebase Used by openshift-ci bot. labels Apr 15, 2020
@JAORMX
Copy link
Contributor

JAORMX commented Apr 21, 2020

/test all

@vojtapolasek vojtapolasek modified the milestones: 0.1.50, 0.1.51 May 15, 2020
@jan-cerny
Copy link
Collaborator

@openscap-ci test this please

@vojtapolasek vojtapolasek modified the milestones: 0.1.51, 0.1.52 Jul 17, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Used by openshift-ci bot. label Jul 22, 2020
@redhatrises redhatrises force-pushed the full_ids branch 4 times, most recently from 1b8f94f to 746cdc8 Compare July 23, 2020 16:42
@redhatrises redhatrises marked this pull request as ready for review July 23, 2020 21:01
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 23, 2020
@redhatrises
Copy link
Contributor Author

This PR is now ready for review.

@mildas
Copy link
Contributor

mildas commented Jul 27, 2020

Changes identified:
Others:
 Python abstract syntax tree change found in ssg/build_remediations.py.
 Python abstract syntax tree change found in ssg/build_yaml.py.
 Python abstract syntax tree change found in ssg/constants.py.
 Python abstract syntax tree change found in tests/unit/ssg-module/test_build_yaml.py.

Recommended tests to execute:
 (cd build && cmake ../ && ctest -j4)

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 27, 2020 •
edited
Loading

@redhatrises: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-moderate 21f1205 link /test e2e-aws-moderate
ci/prow/e2e-aws-e8 21f1205 link /test e2e-aws-e8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@isimluk
Copy link
Member

isimluk commented Jul 28, 2020

LGTM.

Initially, I was not applauding to expansion of text/ids, however longer I think about this more I like it. You just lowered the bar for content contribution as authors no longer need to know details of the build system to see what a given number means! 👏

@redhatrises
Copy link
Contributor Author

/retest

1 similar comment
@isimluk
Copy link
Member

isimluk commented Jul 28, 2020

/retest

@isimluk isimluk merged commit 9e78522 into ComplianceAsCode:master Jul 28, 2020
@redhatrises redhatrises deleted the full_ids branch July 28, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isimluk isimluk isimluk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.52
Development

Successfully merging this pull request may close these issues.
7 participants
@redhatrises @JAORMX @jan-cerny @mildas @openshift-ci-robot @isimluk @vojtapolasek