Skip to content

Update CA file path #13328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jan-cerny
Copy link
Collaborator

This commit will update rule rsyslog_remote_tls_cacert. In RHEL 10 and F43, the file /etc/pki/tls/cert.pem is removed. Instead, we can use /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem as a safe default.
See: https://fedoraproject.org/wiki/Changes/dropingOfCertPemFile

Fixes: https://issues.redhat.com/browse/OPENSCAP-4880

This commit will update rule `rsyslog_remote_tls_cacert`.
In RHEL 10 and F43, the file `/etc/pki/tls/cert.pem` is removed.
Instead, we can use `/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem`
as a safe default.
See: https://fedoraproject.org/wiki/Changes/dropingOfCertPemFile

Fixes: https://issues.redhat.com/browse/OPENSCAP-4880
@jan-cerny jan-cerny added Update Rule Issues or pull requests related to Rules updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Apr 15, 2025
@jan-cerny jan-cerny added this to the 0.1.77 milestone Apr 15, 2025
@Mab879 Mab879 self-assigned this Apr 16, 2025
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, just wondering if we should use product properties for this.

title: 'Configure CA certificate for rsyslog remote logging'

{{% if product in ["fedora", "rhel10" ] %}}
{{# https://fedoraproject.org/wiki/Changes/dropingOfCertPemFile #}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we place this as product property?

@jan-cerny
Copy link
Collaborator Author

I have placed a product property

Copy link

codeclimate bot commented Apr 16, 2025

Code Climate has analyzed commit 3207a8d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@Xeicker Xeicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL10 Red Hat Enterprise Linux 10 product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants