-
Notifications
You must be signed in to change notification settings - Fork 737
Update CA file path #13328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update CA file path #13328
Conversation
This commit will update rule `rsyslog_remote_tls_cacert`. In RHEL 10 and F43, the file `/etc/pki/tls/cert.pem` is removed. Instead, we can use `/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem` as a safe default. See: https://fedoraproject.org/wiki/Changes/dropingOfCertPemFile Fixes: https://issues.redhat.com/browse/OPENSCAP-4880
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, just wondering if we should use product properties for this.
title: 'Configure CA certificate for rsyslog remote logging' | ||
|
||
{{% if product in ["fedora", "rhel10" ] %}} | ||
{{# https://fedoraproject.org/wiki/Changes/dropingOfCertPemFile #}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we place this as product property?
I have placed a product property |
Code Climate has analyzed commit 3207a8d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
This commit will update rule
rsyslog_remote_tls_cacert
. In RHEL 10 and F43, the file/etc/pki/tls/cert.pem
is removed. Instead, we can use/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
as a safe default.See: https://fedoraproject.org/wiki/Changes/dropingOfCertPemFile
Fixes: https://issues.redhat.com/browse/OPENSCAP-4880