Skip to content

remove scapval test from gating #13250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • exclude the /static-tests/nist-validation from tests being run as gating for PRs

Rationale:

  • This test is often failing because of unrelated reasons such as third party sites not being available
  • also usefulness of such a test in PR gating is small because our datastreams will always fail some parts of the SCAP validation process

Review Hints:

  • check gating tests and ensure that the /static-tests/nist-validation test is not executed

@vojtapolasek vojtapolasek added the Test Suite Update in Test Suite. label Mar 28, 2025
@vojtapolasek vojtapolasek added this to the 0.1.77 milestone Mar 28, 2025
@Mab879
Copy link
Member

Mab879 commented Mar 28, 2025

/retest

Copy link

codeclimate bot commented Mar 28, 2025

Code Climate has analyzed commit 7aa90f2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 62.0% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Mar 28, 2025

/retest-required

@jan-cerny jan-cerny self-assigned this Mar 31, 2025
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked that both CS8 and CS9 static-checks jobs don't contain the nist-validation test.

@jan-cerny jan-cerny merged commit 3336c0d into ComplianceAsCode:master Mar 31, 2025
110 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants