Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement Zitadel IDP #549

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Foxtrek64
Copy link

Closes #350

This PR implements an Aspire integration to add support for the Zitadel IDP (https://zitadel.com).

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@Foxtrek64 Foxtrek64 marked this pull request as draft March 8, 2025 20:23
@Foxtrek64
Copy link
Author

This PR contains a couple missing features currently:

  • Docs have yet to be written
  • Tests have yet to be written
  • There is no integration with a CockroachDB or PostgreSQL database for Zitadel to store data.
  • Health check has not yet been implemented.

I had these in my original code, but it seems to have been lost to time so I've needed to recreate it from scratch.

builder.AddParameter
(
name: $"{name}-password",
valueGetter: () => "Password1!",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at how the other resources implement default passwords. None are hardcoded and we do random password generation. https://github.com/dotnet/aspire/blob/cf14299e30838ccfd369ee416c5d962409fd4e5a/src/Aspire.Hosting.MySql/MySqlBuilderExtensions.cs#L35

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw that. Wasn't sure if I should use the documented default value or generate it. I'll switch to the generated password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component - Add custom Zitadel IDP component to aspire
2 participants