Feat: payment selector #8
Open
+487
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new export and interface to the script to allow for easier implementation of a payment process, it provides a base system to allow players to choose how to pay be it with their personal account, group account or even using cash. UI page was built using the same structure as the atm view.
Current behaviour is that the user only has one attempt to pay, if it fails there needs to be another call made via the export to start again.
It was a personal decision to have cash listed as a selectable option mixed in to the accounts for simplicity and avoiding extra code for potentially only a minor improvement.
Previews: