compare tarball string as well in the generation phase to prevent bad tarball url #2487
Conversation
|
|
||
| // Generate tarball url if missing | ||
| if ( versionMetadata.getDist() == null ) | ||
| if ( versionMetadata.getDist() == null || !versionMetadata.getDist().getTarball().endsWith(packagePath.getTarPath()) ) |
There was a problem hiding this comment.
The original dist may contain other info that we should keep them as it is, ref: https://github.com/npm/registry/blob/main/docs/responses/package-metadata.md#dist
Or do we need to compare this, can we simply make it in else branch ? to avoid the potential null pointer exception.
There was a problem hiding this comment.
I have updated it to keep those extra data
And btw do we have linter or formatter?
| versionMetadata.setDist( new Dist( tarball ) ); | ||
| versionMetadata.setDist( new Dist( tarball ) ); | ||
| } else { | ||
| if ( !versionMetadata.getDist().getTarball().endsWith(packagePath.getTarPath()) ) |
There was a problem hiding this comment.
There is a potential NULL pointer exception if the getTarball() returning NULL.
There was a problem hiding this comment.
I thought tarball can't be null if dist is not
fixed
| } else { | ||
| if ( !versionMetadata.getDist().getTarball().endsWith(packagePath.getTarPath()) ) | ||
| { | ||
| versionMetadata.setDist( new Dist( tarball, versionMetadata.getDist().getShasum(), versionMetadata.getDist().getIntegrity(), |
There was a problem hiding this comment.
Is there a better way to avoid repeating call of versionMetadata.getDist() ? And seems we just need to update tarball, how about adding setter in Dist ?
|
LGTM. |
2 participants
No description provided.