Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCHIVE-ENABLED] Implement large file streaming for proxy GET #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdcasey
Copy link
Member

@jdcasey jdcasey commented Nov 8, 2021

Add a new implementation of StreamingOutput to handle ProxyService.get. This implementation takes on responsibility for computing digest values as well, using a smaller transfer buffer to avoid buffering the whole file in memory (to avoid having a large file cause a spike in heap usage).

NOTE: This patch has NOT been tested for memory performance.

@jdcasey jdcasey changed the title Implement large file streaming for proxy GET [ARCHIVE-ENABLED] Implement large file streaming for proxy GET Nov 8, 2021
@jdcasey jdcasey requested review from ligangty and yma96 November 8, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant