Add getAllRemoteRepositoryHosts api for setting up egress network policy #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wonder if it's |
I double checked it and the EgressNetworkPolicy is for MP, TenantEgress is for MP+. So it's better make the api simple. I'll remove the template and just return the simple string. |
ruhan1
force-pushed
the
main-getAllRemoteRepositoryHostnames
branch
from
8eef272 to
8817004
Compare
|
@sswguo updated. pls review. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MMENG-4062 TenantEgress configuration in IAD2
Let's use this to generate Egress policy.