Feature/mock oracle configurable prices failure injection per asset#382
Open
soomtochukwu wants to merge 2 commits intoCommitlabs-Org:masterfrom
Conversation
I implemented extensive unit tests covering APY validation, capacity validation, and invalid input handling for the register_pool function. The tests verify security boundaries, authorization requirements, and edge cases to ensure robust input validation. Tests include boundary value testing, unauthorized access prevention, duplicate ID rejection, and proper error code handling. All tests follow the project's existing patterns and provide comprehensive coverage of the register_pool function's validation logic.
I updated mock_oracle read entrypoints to honor test-mode price overrides consistently. I added per-asset failure injection while preserving legacy global behavior. I expanded unit tests and verified `cargo test -p mock_oracle` passes. Made-with: Cursor
|
@soomtochukwu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the mock_oracle read entrypoints to honour test-mode price overrides consistently.
I added per-asset failure injection while preserving legacy global behaviour.
I expanded unit tests and verified
cargo test -p mock_oraclepasses.$
cargo test -p mock_oracleCloses #279