feat: implement Fee Collection and Management System#378
Open
Olowodarey wants to merge 1 commit intoCommitlabs-Org:masterfrom
Open
feat: implement Fee Collection and Management System#378Olowodarey wants to merge 1 commit intoCommitlabs-Org:masterfrom
Olowodarey wants to merge 1 commit intoCommitlabs-Org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a comprehensive Fee Collection and Management System for the
commitment_corecontract, fully aligning on-chain logic with the specifications defined inFEES.md.The system introduces configurable creation fees, protocol revenue from early exits, per-asset fee tracking, and secure admin-controlled withdrawal mechanisms.
✨ Key Features
🗄️ Storage Infrastructure
Added new storage keys to
DataKey:FeeRecipient— Protocol treasury addressCreationFeeBps— Fee rate in basis points (0–10000)CollectedFees(Address)— Tracks accumulated fees per assetcloses #294