Init tracing log should use provided log_dir_path#239
Merged
ltitanb merged 2 commits intoCommit-Boost:mainfrom Jan 16, 2025
Merged
Init tracing log should use provided log_dir_path#239ltitanb merged 2 commits intoCommit-Boost:mainfrom
ltitanb merged 2 commits intoCommit-Boost:mainfrom
Conversation
Collaborator
|
Thanks, for future reference this works also because of commit-boost-client/crates/common/src/config/log.rs Lines 32 to 37 in 7fa6838 by itself the path in the config file would not work if running inside docker, but this is overridden with |
Contributor
Author
|
Thanks for clarifying this, I'm using this as a pre-cursor to close an issue at Bolt boost client, I can't find the issue atm |
Contributor
Author
|
Ah found it chainbound/bolt#271 |
Collaborator
|
Can you please fix lint? |
Contributor
Author
|
thanks 7671e95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly pass in
LogsSettingslog_dir_path field for extensibility. If not set or defined it would fallback to default as shown below:commit-boost-client/crates/common/src/config/log.rs
Lines 18 to 21 in ae38647
Closes #237