Skip to content

style: update ui and design of system notification components (what's new, new release notification, help center) #6300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
+1,386 −993
Open

style: update ui and design of system notification components (what's new, new release notification, help center) #6300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
53a3c68
update notifications components designs
christian-byrne Oct 26, 2025
2c425a1
fix stylelint issues
christian-byrne Oct 26, 2025
4b3e9f2
fix test locator
christian-byrne Oct 26, 2025
f459402
update release notification components with semantic design tokens
christian-byrne Oct 29, 2025
f9670c5
fix notification component tests and remove temporary mock data
christian-byrne Nov 6, 2025
450a0f2
implement new designs
christian-byrne Nov 7, 2025
fb4c782
fix test
christian-byrne Nov 7, 2025
4ce6425
update style
christian-byrne Nov 13, 2025
8b134b4
use correct tokens
christian-byrne Nov 13, 2025
8dd416b
remove border radius token
christian-byrne Nov 14, 2025
b7897cd
[feat] Implement proper design tokens and Storybook stories for relea…
christian-byrne Nov 27, 2025
6d82001
add i18n
christian-byrne Nov 27, 2025
4fbeafc
[fix] Fix notification component tests and improve empty content hand…
christian-byrne Nov 30, 2025
6f3dd70
[security] Fix XSS vulnerability in notification components
christian-byrne Nov 30, 2025
11775ff
[fix] Replace hardcoded strings with i18n and fix rel attribute
christian-byrne Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions browser_tests/tests/releaseNotifications.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Verify "What's New?" section shows the release
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).toBeVisible()

// Should show the release version
Expand Down Expand Up @@ -79,7 +79,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Verify "What's New?" section shows no releases
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).toBeVisible()

// Should show "No recent releases" message
Expand Down Expand Up @@ -125,7 +125,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Should show no releases due to error
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(
whatsNewSection.locator('text=No recent releases')
).toBeVisible()
Expand Down Expand Up @@ -175,7 +175,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Verify "What's New?" section is hidden
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).not.toBeVisible()

// Should not show any popups or toasts
Expand Down Expand Up @@ -263,7 +263,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Verify "What's New?" section is visible
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).toBeVisible()

// Should show the release
Expand Down Expand Up @@ -311,7 +311,7 @@ test.describe('Release Notifications', () => {
await helpCenterButton.click()

// Verify "What's New?" section is visible
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).toBeVisible()

// Close help center
Expand Down Expand Up @@ -362,7 +362,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Section should be hidden regardless of empty releases
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).not.toBeVisible()
})
})
10 changes: 10 additions & 0 deletions packages/design-system/src/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@
--color-danger-100: #c02323;
--color-danger-200: #d62952;



--color-coral-red-600: #973a40;
--color-coral-red-500: #c53f49;
--color-coral-red-400: #dd424e;
Expand Down Expand Up @@ -183,9 +185,13 @@
--interface-menu-component-surface-hovered: var(--color-smoke-200);
--interface-menu-component-surface-selected: var(--color-smoke-400);
--interface-menu-keybind-surface-default: var(--color-smoke-500);
--interface-menu-surface: var(--color-white);
--interface-menu-stroke: var(--color-smoke-600);
--interface-panel-surface: var(--color-white);
--interface-stroke: var(--color-smoke-300);



--nav-background: var(--color-white);

--node-border: var(--color-smoke-300);
Expand Down Expand Up @@ -301,6 +307,8 @@
--interface-menu-component-surface-hovered: var(--color-charcoal-400);
--interface-menu-component-surface-selected: var(--color-charcoal-300);
--interface-menu-keybind-surface-default: var(--color-charcoal-200);
--interface-menu-surface: var(--color-charcoal-800);
--interface-menu-stroke: var(--color-ash-800);
--interface-panel-surface: var(--color-charcoal-800);
--interface-stroke: var(--color-charcoal-400);

Expand Down Expand Up @@ -416,6 +424,8 @@
--color-interface-menu-keybind-surface-default: var(
--interface-menu-keybind-surface-default
);
--color-interface-menu-surface: var(--interface-menu-surface);
--color-interface-menu-stroke: var(--interface-menu-stroke);
--color-interface-panel-surface: var(--interface-panel-surface);
--color-interface-panel-hover-surface: var(--interface-panel-hover-surface);
--color-interface-panel-selected-surface: var(
Expand Down
Loading