-
Notifications
You must be signed in to change notification settings - Fork 1.8k
📂 Majoor Assets Manager for ComfyUI #2378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MajoorWaldi
wants to merge
6
commits into
Comfy-Org:main
Choose a base branch
from
MajoorWaldi:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−0
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ca3d157
Add Majoor File Manager node to custom-node-list
MajoorWaldi 4803491
Rename and update Majoor File Manager to Asset Manager
MajoorWaldi 44bcc85
Fix typos in Majoor Assets Manager entry
MajoorWaldi 1b670e8
Add 'id' field to Majoor Assets Manager entry
MajoorWaldi 0323323
Update custom-node-list.json
ltdrdata b1e1d4f
Merge branch 'Comfy-Org:main' into main
MajoorWaldi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new Majoor Assets Manager block ends with a trailing comma (
},) even though it is the final element before the closing array bracket, leavingcustom-node-list.jsoninvalid JSON. Runningjq empty custom-node-list.jsonnow fails withExpected another array element at line 38709, column 5, so any consumer that parses this list will error out until the comma is removed.Useful? React with 👍 / 👎.