Add new custom node: lora_downloader #2363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"author": "huihuihuiz",
"title": "LoRA Downloader for ComfyUI",
"id": "lora_downloader",
"reference": "https://github.com/huihuihuiz/lora_downloader",
"repo_url": "https://github.com/huihuihuiz/lora_downloader",
"install_type": "git",
"description": "A ComfyUI custom node for downloading and managing LoRA models directly within the UI."
}
Removed Lora_Downloader entry from extension-node-map.json
Member
|
Please use something like os.path.commonpath to ensure that any paths constructed from external input remain within an isolated directory. As it stands, there is a vulnerability that allows writing or reading files at arbitrary locations via relative paths and similar techniques. |
Contributor
Author
|
Thanks for the review. All user-controlled paths have been secured using os.path.commonpath via a safe_join helper, ensuring all file access remains within the allowed directories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the custom node plugin "lora_downloader".
GitHub repo:
https://github.com/huihuihuiz/lora_downloader
description:
A custom node for downloading, organizing, and managing LoRA models directly inside ComfyUI.