Improve comfyui version listing #2333
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| normalized_current = normalize_describe(raw_current_tag) | ||
| has_normalized_tag = normalized_current in semver_tag_set | ||
| current_tag = normalized_current if has_normalized_tag else raw_current_tag |
There was a problem hiding this comment.
When HEAD is ahead of the last release tag, git describe --tags returns values like v1.2.3-15-gabcd, but get_comfyui_versions normalizes this to v1.2.3 and exposes it as current_tag (lines 3292-3294). update_to_stable_comfyui compares current_tag directly to the latest semver tag to decide whether to skip, so nightly commits past the latest release now appear identical to that release and the stable updater exits early, leaving the repository on nightly instead of checking out the tagged stable version.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
It's valid if we use semver, but we have RCs and branches based on release minor versions
also I don't think we would ever be on an untagged HEAD?
|
closing in favor of #2334 |
Summary
Testing