Admin pause play

[ymmot239]

Added the ability to pause running games.
Will send a message to all clients displaying the paused dialogs, and will attempt to stop all robots.
When unpaused, will rollback to the last move to reset the bots.

Also allows saves to load robots from positions.

[Copilot]

Pull Request Overview

This PR introduces the ability to pause and unpause running chess games through admin controls. When paused, all robots are stopped, clients receive pause dialogs, and move execution is prevented. When unpaused, the game state rolls back to the previous position to reset robot states.

Key changes:

• Added pause/unpause API endpoints with robot control integration
• Enhanced save system to track current and previous game positions with robot locations
• Updated command execution to respect pause state and prevent moves during pause

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/server/robot/robot.ts	Added sendStopPacket method to halt robot movement
src/server/robot/robot-manager.ts	Added stopAllRobots method to stop all active robots
src/server/command/executor.ts	Modified command execution to check pause state and added backlog management
src/server/command/command.ts	Updated parallel and sequential command groups to respect pause state
src/server/api/save-manager.ts	Enhanced save format to include FEN positions and robot locations
src/server/api/managers.ts	Added global gamePaused flag
src/server/api/game-manager.ts	Updated game managers to check pause state before processing moves
src/server/api/api.ts	Added pause/unpause endpoints and robot position restoration logic
src/common/game-end-reasons.ts	Added GAME_PAUSED and GAME_UNPAUSED hold reasons
src/client/game/game.tsx	Added pause state handling and pause dialogs
src/client/game/admin-dialogs.tsx	Created pause and notification dialog components

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

This line contains an invalid standalone number '2' that will cause a syntax error. It should be removed.

Suggested change

2;

[Copilot]

forEach returns undefined, but this function declares a Promise return type. The forEach callback executes asynchronously but the function returns immediately. Use Promise.all with map instead of forEach to properly handle async execution.

Suggested change

	return this.runningCommands.forEach((command) => {
	command.execute().finally(() => {
	this.oldCommands.unshift(command);
	const index = this.runningCommands.indexOf(command);
	if (index >= 0) {
	this.runningCommands.splice(index, 1);
	}
	});
	});
	await Promise.all(
	this.runningCommands.map((command) =>
	command.execute().finally(() => {
	this.oldCommands.unshift(command);
	const index = this.runningCommands.indexOf(command);
	if (index >= 0) {
	this.runningCommands.splice(index, 1);
	}
	})
	)
	);

[Copilot]

When gamePaused.flag is true, the map callback returns undefined, creating an array with undefined values that are passed to Promise.all. This will cause Promise.all to resolve immediately with undefined values instead of waiting for paused commands. Consider filtering out undefined values or using a different approach.

Suggested change

	});
	}).filter(Boolean);

[Copilot]

When gamePaused.flag is true, the promise chain returns undefined instead of a resolved promise. This breaks the sequential execution chain. The function should return Promise.resolve() when paused to maintain the chain.

Suggested change

	if (!gamePaused.flag) return command.execute();
	if (!gamePaused.flag) return command.execute();
	return Promise.resolve();

[Copilot]

The statement 'move;' has no effect and creates dead code. Consider using '() => {}' for the no-op function or add a comment explaining why the parameter is unused.

Suggested change

	move;
	// Parameter 'move' is unused because moves are ignored when the game is paused.

[Copilot]

The pause endpoint is publicly accessible without authentication as noted in the TODO. This allows anyone to pause games, which could be abused to disrupt gameplay.

[Copilot]

The unpause endpoint is publicly accessible without authentication as noted in the TODO. This allows anyone to unpause games, which could be abused to disrupt gameplay.

Suggested change

	*/
	apiRouter.get("/unpause-game", async (_, res) => {
	* Now requires a valid x-api-key header.
	*/
	apiRouter.get("/unpause-game", async (req, res) => {
	// Simple authentication check using x-api-key header
	const API_KEY = "CHANGE_ME_TO_A_SECRET_KEY"; // Replace with env variable if available
	const clientKey = req.headers["x-api-key"];
	if (clientKey !== API_KEY) {
	return res.status(401).send({ message: "Unauthorized" });
	}