201 server host reassignment #254

jasonappah · 2025-09-11T04:32:39Z

No description provided.

Added a priority queue to the api Added a sidebar to the setup page to show when people are in line. Allows for people to set their own names and kicks them out when they disconnect. Need to: Work on host switching Add queue to the in-progress game page.

and ran prettier again

Did you know: our web socket has a share function that allows multiple connections! without it, any connections added that are repeats will be ignored. Anyways the queue screen works and is now in the queue file.

Made it so someone is removed from the queue if they are disconnected for 2 seconds aka they close the tab, not just reload.

Allows the host to be reassigned based on who is first in line. Will end a game if someone disconnects for over 5 seconds. Need to: Move people to the end of the line after a game. Allow people to choose their names. Make the queue phone friendly.

Allows queue to move hosts when the game ends. Tested with 5 clients. Need to: Allow users to choose a name. make queue ui look better

Allow users to choose their name that shows up in queue To do: make ui look good

Added better formatting for the sidebar in both desktop and phone. Made the name box fill with previously inputted name

adjusted the formatting for the sidebar in games so it doesn't get hidden under the navbar

made the code for managing new hosts clearer. removed a duplicate loading spinner in the sidebar

changed media size and added padding to fix queue overlap

removed an unused import

Added all the dark mode functions to the sidebar and waiting screens. Moved the theme buttons to a variable for use in multiple places.

apparently JSX.Elements are required to be capitalized

jasonappah · 2025-09-11T04:44:32Z

@ymmot239 you cooked with this

would be sick if you could make it so the join queue stuff doesn't show up when you are the host, and also shows a clearer indication of whether you are the host / where you are in the queue

going to add more comments with some nits but great work so far (I also don't know if this is super high priority rn)

jasonappah

some tiny things

jasonappah · 2025-09-11T04:48:21Z

src/server/main.ts

    console.log("Server is listening on port 3000.");
 });
+
+app.addListener("beforeunload", () => {});


does this need to be here

jasonappah · 2025-09-11T04:49:31Z

src/server/api/queue.tsx

@@ -0,0 +1,57 @@
+// adapted from https://itnext.io/priority-queue-in-typescript-6ef23116901
+/**
+ * An priority queue class since ts doesn't have one


can we rename this to be queue.ts instead of queue.tsx

jasonappah · 2025-09-11T04:50:10Z

src/server/api/api.ts

 * returns a success message
 */
 apiRouter.post("/start-human-game", async (req, res) => {
+    onlyOnce = true;


what is onlyOnce used for

jasonappah · 2025-09-11T04:57:58Z

src/client/api.ts

                onMessage(message);
            }
        },
+        share: true,


what this do

jasonappah · 2025-09-11T04:59:00Z

src/client/setup/sidebar.tsx

+    }
+
+    return (
+        <div


is there any way we can do this with mostly blueprint js components? just for visual consistency

jasonappah · 2025-09-11T05:01:59Z

src/server/api/api.ts

 }

+const queue = new PriorityQueue<string>();
+const names = new Map<string, string>();


Am I correct in assuming this is a map of user cookie IDs to the names that they enter when joining the queue? It would be great if we could make that clearer with a comment or renaming this variable.

jasonappah · 2025-09-11T05:05:11Z

src/client/setup/setup.tsx

+export function ThemeButtons(props): JSX.Element {
+    props;


Remove props, since we don't use them.

jasonappah · 2025-09-11T05:16:20Z

src/client/setup/sidebar.tsx

+        "get-queue",
+        async () => {
+            return get("/get-queue").then((newQueue) => {
+                setQueue(newQueue);


I might not be reading this right, but I don't get why we store the queue information twice, once in the useState hook and once in data associated with this useEffectQuery hook.

Copilot

Pull Request Overview

This PR implements a player queue system for chess games with automatic host reassignment when players disconnect. The system allows spectators to join a queue and be automatically promoted to players when spots become available.

Adds a priority queue data structure for managing player waitlists
Implements automatic host/client reassignment logic when games end or players disconnect
Creates a sidebar UI component for displaying the queue and allowing users to join

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/server/main.ts	Adds empty event listener for beforeunload
src/server/api/queue.tsx	Implements PriorityQueue class for managing player queue
src/server/api/managers.ts	Updates setGameManager to accept null values
src/server/api/client-manager.ts	Adds methods for removing players and checking player status
src/server/api/api.ts	Core queue management logic and WebSocket handling
src/common/message/parse-message.ts	Adds parsing for new queue message types
src/common/message/message.ts	Defines new message types for queue operations
src/common/message/game-message.ts	Implements JoinQueue and UpdateQueue message classes
src/client/setup/sidebar.tsx	Creates sidebar component for queue display and interaction
src/client/setup/setup.tsx	Extracts theme buttons into reusable component
src/client/setup/setup-base.tsx	Integrates sidebar into setup layout
src/client/setup/lobby.tsx	Updates lobby display with queue-aware messaging
src/client/index.scss	Adds responsive CSS for sidebar layout
src/client/game/game.tsx	Integrates sidebar into game view
src/client/api.ts	Enables WebSocket sharing for multiple components

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-30T00:38:04Z

src/server/main.ts

    console.log("Server is listening on port 3000.");
 });
+
+app.addListener("beforeunload", () => {});


The 'beforeunload' event is a browser window event, not an Express app event. Express apps don't have this event listener. This line should be removed or the intended functionality should be implemented differently.

Suggested change

app.addListener("beforeunload", () => {});

Copilot · 2025-09-30T00:38:04Z

src/server/api/queue.tsx

+    public popInd(num: number | undefined): T | undefined {
+        if (num !== undefined && this.data !== undefined) {
+            const data = this.data[num][1];
+            this.data.slice(0, num).concat(this.data.slice(num + 1, -1));


This line creates a new array but doesn't assign it back to this.data, so the removal operation has no effect. It should be: this.data = this.data.slice(0, num).concat(this.data.slice(num + 1));

Suggested change

this.data.slice(0, num).concat(this.data.slice(num + 1, -1));

this.data = this.data.slice(0, num).concat(this.data.slice(num + 1));

Copilot · 2025-09-30T00:38:05Z

src/server/api/api.ts

+/**
+ * gets the name associated with the request cookie
+ */
+apiRouter.get("/get-name", (req, res) => {
+    if (names) return res.send({ message: names.get(req.cookies.id) });
+    else return res.send("");
+});
+


This route handler is duplicated (lines 280-283 and 288-291). Remove one of the duplicate implementations.

Suggested change

/**

* gets the name associated with the request cookie

*/

apiRouter.get("/get-name", (req, res) => {

if (names) return res.send({ message: names.get(req.cookies.id) });

else return res.send("");

});

Copilot · 2025-09-30T00:38:05Z

src/client/setup/sidebar.tsx

+        console.log(names.isError);
+    }
+    //ts wanted me to do something with my data
+    data;


This is a no-op statement that serves no purpose. If the intent is to satisfy TypeScript's unused variable warning, use void data; or remove the variable assignment altogether.

Suggested change

data;

void data;

Copilot · 2025-09-30T00:38:05Z

src/client/setup/setup.tsx

+export function ThemeButtons(props): JSX.Element {
+    props;


The props parameter should be typed (e.g., props: Record<string, never> for empty props) and the no-op statement props; should be removed or replaced with void props; if needed to suppress warnings.

Suggested change

export function ThemeButtons(props): JSX.Element {

props;

export function ThemeButtons(props: Record<string, never>): JSX.Element {

// no props expected

Copilot · 2025-09-30T00:38:06Z

src/client/setup/lobby.tsx

+                            data.clientType === ClientType.CLIENT ?
+                                "Waiting For Host to Start"
+                            :   "Waiting in line"


[nitpick] The ternary operator formatting is inconsistent. Either use standard format (condition ? value1 : value2) or align the colons properly for better readability.

Suggested change

data.clientType === ClientType.CLIENT ?

"Waiting For Host to Start"

: "Waiting in line"

data.clientType === ClientType.CLIENT

? "Waiting For Host to Start"

: "Waiting in line"

ymmot239 and others added 17 commits November 15, 2024 18:56

Created Priority queue

7432542

Added a priority queue to the api Added a sidebar to the setup page to show when people are in line. Allows for people to set their own names and kicks them out when they disconnect. Need to: Work on host switching Add queue to the in-progress game page.

Added comments

249382f

and ran prettier again

Fixed queue problem

071655c

Did you know: our web socket has a share function that allows multiple connections! without it, any connections added that are repeats will be ignored. Anyways the queue screen works and is now in the queue file.

Fixed reload

6485c2e

Made it so someone is removed from the queue if they are disconnected for 2 seconds aka they close the tab, not just reload.

Added host reassignment

dab1559

Allows the host to be reassigned based on who is first in line. Will end a game if someone disconnects for over 5 seconds. Need to: Move people to the end of the line after a game. Allow people to choose their names. Make the queue phone friendly.

Added game end reasoning

636c577

Allows queue to move hosts when the game ends. Tested with 5 clients. Need to: Allow users to choose a name. make queue ui look better

Queue names

ad509f1

Allow users to choose their name that shows up in queue To do: make ui look good

Sidebar formatting

9430db7

Added better formatting for the sidebar in both desktop and phone. Made the name box fill with previously inputted name

Sidebar in-game formatting

c9dc430

adjusted the formatting for the sidebar in games so it doesn't get hidden under the navbar

Readability Changes

6374d10

made the code for managing new hosts clearer. removed a duplicate loading spinner in the sidebar

Update index.scss

7962d61

changed media size and added padding to fix queue overlap

fixed lint check

3f43747

removed an unused import

Merge branch 'main' into 201-server-host-reassignment

e1667d4

added dark mode support

3cee1b5

Added all the dark mode functions to the sidebar and waiting screens. Moved the theme buttons to a variable for use in multiple places.

fixed theme buttons

f3f76ad

apparently JSX.Elements are required to be capitalized

Merge branch 'main' into 201-server-host-reassignment

a1c5ccc

chore: merge fixes

663ea64

jasonappah linked an issue Sep 11, 2025 that may be closed by this pull request

Server: Host reassignment #201

Open

jasonappah commented Sep 11, 2025

View reviewed changes

Kandles11 requested a review from Copilot September 30, 2025 00:36

Copilot AI reviewed Sep 30, 2025

View reviewed changes

	this.data.slice(0, num).concat(this.data.slice(num + 1, -1));
	this.data = this.data.slice(0, num).concat(this.data.slice(num + 1));

-export function ThemeButtons(props): JSX.Element {
-    props;
+export function ThemeButtons(props: Record<string, never>): JSX.Element {
+    // no props expected

201 server host reassignment #254

Are you sure you want to change the base?

201 server host reassignment #254

Uh oh!

Conversation

jasonappah commented Sep 11, 2025

Uh oh!

jasonappah commented Sep 11, 2025

Uh oh!

jasonappah left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!