Skip to content

Conversation

@amanmahajan7
Copy link
Collaborator

No description provided.

@amanmahajan7 amanmahajan7 self-assigned this Nov 22, 2024
@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.63%. Comparing base (a606cdd) to head (112924e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/DataGrid.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
- Coverage   90.84%   89.63%   -1.22%     
==========================================
  Files          48       48              
  Lines        3453     3453              
  Branches      665      657       -8     
==========================================
- Hits         3137     3095      -42     
- Misses        316      358      +42     
Files with missing lines Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/DataGrid.tsx 82.16% <0.00%> (-4.60%) ⬇️

... and 5 files with indirect coverage changes

---- 🚨 Try these New Features:

Comment on lines 773 to 775
rowIdx: position.rowIdx,
row,
row: isRowIdxWithinViewportBounds(position.rowIdx) ? rows[position.rowIdx] : undefined,
column: columns[position.idx]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can change the type to include row type similar to
https://github.com/adazzle/react-data-grid/blob/main/src/types.ts#L284

@amanmahajan7 amanmahajan7 marked this pull request as ready for review November 22, 2024 15:08
@amanmahajan7 amanmahajan7 merged commit e79641b into main Nov 22, 2024
3 checks passed
@amanmahajan7 amanmahajan7 deleted the am-fix-onSelectedCellChange branch November 22, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants