Migrate remaining tests to vitest-browser-react and browserUserEvent
#3640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3640 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 47 47
Lines 3426 3426
Branches 742 742
=======================================
Hits 3380 3380
Misses 46 46 🚀 New features to boost your workflow:
|
amanmahajan7
commented
Mar 19, 2025
| const resizeHandle = getResizeHandle(column); | ||
|
|
||
| await resizeHandle.dblClick(); | ||
| await userEvent.dblClick(resizeHandle); |
Collaborator
Author
There was a problem hiding this comment.
Added userEvent back for consistency
nstepien
reviewed
Mar 19, 2025
package.json
Outdated
| "@testing-library/dom": "^10.1.0", | ||
| "@testing-library/react": "^16.2.0", | ||
| "@testing-library/user-event": "^14.5.2", | ||
| "@testing-library/dom": "^10.4.0", |
Collaborator
There was a problem hiding this comment.
Do we need to keep this?
Collaborator
Author
There was a problem hiding this comment.
build fails without it
Collaborator
There was a problem hiding this comment.
It's an explicit dependency of @vitest/browser, might be a recent change
nstepien
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/vitest-dev/vitest-browser-react
https://vitest.dev/guide/browser/interactivity-api.html