Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html theme #10

Merged
merged 2 commits into from
May 15, 2024
Merged

Add html theme #10

merged 2 commits into from
May 15, 2024

Conversation

shenvitor
Copy link
Member

@shenvitor shenvitor commented May 15, 2024

As the title says.

@shenvitor shenvitor self-assigned this May 15, 2024
@shenvitor shenvitor requested a review from redeboer May 15, 2024 13:18
@redeboer
Copy link
Member

redeboer commented May 15, 2024

Before switching between themes too frequently, it's better to decide on one theme. I would use either

The latter has the advantages that it works best with myst-nb as it is developed by the same group. Note that sphinx-book-theme is just wraps pydata-sphinx-theme, so using a subset is fine as well.

Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 😏 Approved 🔥

Just a thought though: it seems that pydata puts each page on the top navigation bar, which isn't really scalable (you can't scroll horizontally). I sure it's possible to move them to the sidebar, so we can look at that once there are more notebooks.
(This is incidentally why I prefer sphinx-book-theme — it has some convenience settings that make it easier to move the pages between sidebar and navbar.)

image

@shenvitor
Copy link
Member Author

shenvitor commented May 15, 2024

Layout can be modified in the future.
https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/layout.html#header-navigation-bar

Looks nice 😏 Approved 🔥

Just a thought though: it seems that pydata puts each page on the top navigation bar, which isn't really scalable (you can't scroll horizontally). I sure it's possible to move them to the sidebar, so we can look at that once there are more notebooks. (This is incidentally why I prefer sphinx-book-theme — it has some convenience settings that make it easier to move the pages between sidebar and navbar.)

image

@shenvitor shenvitor merged commit 9c74246 into main May 15, 2024
3 checks passed
@shenvitor shenvitor deleted the html-theme branch May 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants