Skip to content

Fix Cython compilation error in LimitOrder age methods #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamsturg wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix Cython compilation error in LimitOrder age methods #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hummingbot/core/data_type/limit_order.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ from .LimitOrder cimport LimitOrder as CPPLimitOrder
cdef class LimitOrder:
cdef:
CPPLimitOrder _cpp_limit_order
cdef long long c_age(self)
cdef long long c_age_til(self, long long start_timestamp)
cdef double c_age(self)
cdef double c_age_til(self, long long start_timestamp)


cdef LimitOrder c_create_limit_order_from_cpp_limit_order(const CPPLimitOrder cpp_limit_order)
12 changes: 6 additions & 6 deletions hummingbot/core/data_type/limit_order.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ cdef class LimitOrder:
list data = []
str order_id_txt, type_txt, spread_txt, age_txt, hang_txt
double price, quantity
long long age_seconds
double age_seconds
long long now_timestamp = int(time.time() * 1e6) if end_time_order_age == 0 else end_time_order_age
sells.extend(buys)
for order in sells:
Expand Down Expand Up @@ -145,7 +145,7 @@ cdef class LimitOrder:
str retval = cpp_position.decode("utf8")
return PositionAction(retval)

cdef long long c_age_til(self, long long end_timestamp):
cdef double c_age_til(self, long long end_timestamp):
"""
Calculates and returns age of the order since it was created til end_timestamp in seconds
:param end_timestamp: The end timestamp
Expand All @@ -159,19 +159,19 @@ cdef class LimitOrder:
if 0 < start_timestamp < end_timestamp:
return int(end_timestamp - start_timestamp) / 1e6
else:
return -1
return -1.0

cdef long long c_age(self):
cdef double c_age(self):
"""
Calculates and returns age of the order since it was created til now.
"""
return self.c_age_til(int(time.time() * 1e6))

def age(self) -> int:
return self.c_age()
return int(self.c_age())

def age_til(self, start_timestamp: int) -> int:
return self.c_age_til(start_timestamp)
return int(self.c_age_til(start_timestamp))

def order_type(self) -> OrderType:
return OrderType.LIMIT
Expand Down