-
Notifications
You must be signed in to change notification settings - Fork 3
feat(medcat-den): CU-869an5f00 Add remote api #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mart-r
wants to merge
17
commits into
main
Choose a base branch
from
feat/medcat-den/CU-869an5f00-add-remote-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task linked: CU-869an5f00 Move medcat-den to cogstack-nlp |
That is, needed to make sure it is explicitly specced for the protocol for the instanceof check to pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 2 parter:
1 - new API designed for remote dens
This PR adds optional API that's designed for use with a remote den. The API is not available for local dens.
This API is designed to make all the processing (either fine-tuning or metrics / eval) to happen on the remote.
The imagined workflow would look something like that:
2 - new config options designed for use with remote dens
With remote dens, you generally don't want the user to fine tuning and/or evaluation locally.
Instead, you want this to be done on the remote den so that the experiments can be kept track of.
So this PR adds a few config options / environmental variables (that only affect remote dens):
So by default, a remote den will not allow local fine-tuning or pushing of a fine-tuned model back to the remote. However, this behaviour can be changed if/when needed. This generally does not affect new models which should still be able to be pushed to the remote den.