Production ready

fixed test

Author: stesee

PuppeteerSharp.RendererTests/DocumentAsserter.cs

@@ -8,43 +8,48 @@ namespace PuppeteerSharp.RendererTests
 {
     internal static class DocumentAsserter
     {
-        internal static void AssertImageIsEqual(string actualImagePath, string expectImageFilePath)
+        internal static void AssertImageIsEqual(string actualImagePath, string expectImageFilePath, int allowedPixelErrorCount)
         {
             var actualFullPath = Path.GetFullPath(actualImagePath);
             var expectFullPath = Path.GetFullPath(expectImageFilePath);
 
             Assert.True(File.Exists(actualFullPath), $"actualImagePath not found {actualFullPath}");
             Assert.True(File.Exists(expectFullPath), $"ExpectReferenceImagePath not found \n{expectFullPath}\n copy over \n{actualFullPath}\n if this is a new test case.");
+            var base64fyedActualImage = Convert.ToBase64String(File.ReadAllBytes(actualFullPath));
 
             if (ImageSharpCompare.ImageAreEqual(actualFullPath, expectFullPath))
             {
                 return;
             }
 
-            var osSpezificDiffFileSuffix = RuntimeInformation.IsOSPlatform(OSPlatform.Linux) ? "linux" : "win";
+            var osSpecificDiffFileSuffix = RuntimeInformation.IsOSPlatform(OSPlatform.Linux) ? "linux" : "win";
 
-            var allowedDiffImage = $"{expectFullPath}.diff.{osSpezificDiffFileSuffix}.png";
+            var allowedDiffImage = $"{expectFullPath}.diff.{osSpecificDiffFileSuffix}.png";
+            var newDiffImage = $"{actualFullPath}.diff.png";
+            using (var fileStreamDifferenceMask = File.Create(newDiffImage))
+            using (var maskImage = ImageSharpCompare.CalcDiffMaskImage(actualFullPath, expectFullPath))
+            {
+                SixLabors.ImageSharp.ImageExtensions.SaveAsPng(maskImage, fileStreamDifferenceMask);
+            }
+            var base64fyedImageDiff = Convert.ToBase64String(File.ReadAllBytes(newDiffImage));
 
             if (File.Exists(allowedDiffImage))
             {
-                var result = ImageSharpCompare.CalcDiff(actualFullPath, expectFullPath, allowedDiffImage);
+                var resultWithAllowedDiff = ImageSharpCompare.CalcDiff(actualFullPath, expectFullPath, allowedDiffImage);
 
-                if (result.AbsoluteError == 0)
-                {
-                    return;
-                }
+                Assert.True(resultWithAllowedDiff.PixelErrorCount <= allowedPixelErrorCount, $"Expected PixelErrorCount beyond {allowedPixelErrorCount} but was {resultWithAllowedDiff.PixelErrorCount}\nExpected {expectFullPath}\ndiffers to actual {actualFullPath}\n {base64fyedActualImage}\n \n Diff is {newDiffImage} \n {base64fyedImageDiff}\n");
+                return;
             }
 
-            var newDiffImage = $"{actualFullPath}.diff.png";
             using (var fileStreamDifferenceMask = File.Create(newDiffImage))
             using (var maskImage = ImageSharpCompare.CalcDiffMaskImage(actualFullPath, expectFullPath))
             {
                 SixLabors.ImageSharp.ImageExtensions.SaveAsPng(maskImage, fileStreamDifferenceMask);
             }
 
-            var base64fyedActualImage = Convert.ToBase64String(File.ReadAllBytes(actualFullPath));
-            var base64fyedImageDiff = Convert.ToBase64String(File.ReadAllBytes(newDiffImage));
-            Assert.True(ImageSharpCompare.ImageAreEqual(actualFullPath, expectFullPath), $"Expected {expectFullPath}\ndiffers to actual {actualFullPath}\n {base64fyedActualImage}\n \n Diff is {newDiffImage} \n {base64fyedImageDiff}\n");
+            var result = ImageSharpCompare.CalcDiff(actualFullPath, expectFullPath);
+
+            Assert.True(result.PixelErrorCount <= allowedPixelErrorCount, $"Expected PixelErrorCount beyond {allowedPixelErrorCount} but was {result.PixelErrorCount}\nExpected {expectFullPath}\ndiffers to actual {actualFullPath}\n {base64fyedActualImage}\n \n Diff is {newDiffImage} \n {base64fyedImageDiff}\nReplace {actualFullPath} with the new value or store the diff as {allowedDiffImage}.");
         }
     }
 }

PuppeteerSharp.RendererTests/ExpectedTestOutcome/ExpectedConvertHtmlToPngBasicTextFormated.html.png

@@ -31,7 +31,7 @@ public async Task ShouldConvertHtmlToPdf(string testFileName)
             var actualImages = await rasterize.ConvertToPngAsync(actualFilePath, actualImagePathDirectory);
 
             Assert.Single(actualImages);
-            DocumentAsserter.AssertImageIsEqual(actualImages.Single(), expectReferenceFilePath);
+            DocumentAsserter.AssertImageIsEqual(actualImages.Single(), expectReferenceFilePath, 50);
         }
 
         [Theory]
@@ -51,7 +51,7 @@ public async Task ShouldConvertHtmlToPng(string testFileName)
 
             await chromiumRenderer.ConvertHtmlToPng(sourceHtmlFilePath, actualFilePath);
 
-            DocumentAsserter.AssertImageIsEqual(actualFilePath, expectReferenceFilePath);
+            DocumentAsserter.AssertImageIsEqual(actualFilePath, expectReferenceFilePath, 50);
         }
     }
 }