Production ready

Author: stesee

PuppeteerSharp.Renderer/PuppeteerSharp.Renderer.csproj

@@ -36,7 +36,7 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="all" />
     <PackageReference Include="PuppeteerSharp" Version="2.0.4" />
-    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.15.0.24505">
+    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.18.0.27296">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

PuppeteerSharp.Renderer/Renderer.cs

@@ -72,9 +72,9 @@ public async Task ConvertHtmlToPdf(string sourceHtmlFilePath, string destination
         /// Converts a HTML file to a PNG
         /// </summary>
         /// <param name="sourceHtmlFilePath"></param>
-        /// <param name="destinationPdfFilePath"></param>
+        /// <param name="destinationPngFilePath"></param>
         /// <returns></returns>
-        public async Task ConvertHtmlToPng(string sourceHtmlFilePath, string destinationPdfFilePath)
+        public async Task ConvertHtmlToPng(string sourceHtmlFilePath, string destinationPngFilePath)
         {
             if (!File.Exists(sourceHtmlFilePath))
             {
@@ -84,7 +84,7 @@ public async Task ConvertHtmlToPng(string sourceHtmlFilePath, string destination
             var absolutePath = Path.GetFullPath(sourceHtmlFilePath);
             var page = await Browser.NewPageAsync().ConfigureAwait(false);
             await page.GoToAsync($"file://{absolutePath}").ConfigureAwait(false);
-            await page.ScreenshotAsync(destinationPdfFilePath, new ScreenshotOptions() { FullPage = true }).ConfigureAwait(false);
+            await page.ScreenshotAsync(destinationPngFilePath, new ScreenshotOptions() { FullPage = true }).ConfigureAwait(false);
         }
 
         private void DownloadProgressChanged(object sender, DownloadProgressChangedEventArgs e)

PuppeteerSharp.RendererCliTests/PuppeteerSharp.RendererCliTests.csproj

@@ -7,16 +7,12 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.7.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="coverlet.collector" Version="1.3.0">
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-      <PrivateAssets>all</PrivateAssets>
-    </PackageReference>
   </ItemGroup>
 
   <ItemGroup>

PuppeteerSharp.RendererCliTests/UnitTest1.cs renamed to PuppeteerSharp.RendererCliTests/RendererCliTests.cs

@@ -6,7 +6,7 @@
 
 namespace PuppeteerSharp.RendererCliTests
 {
-    public class UnitTest1
+    public class RendererCliTests
     {
         [Fact]
         public void VersionShouldBeProcessed()

PuppeteerSharp.RendererTests/ExpectedTestOutcome/ExpectedConvertHtmlToPngBasicTextFormated.html.png.diff.linux.png

@@ -16,9 +16,9 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="ImageSharpCompare" Version="1.0.27" />
-    <PackageReference Include="PdfjsSharp" Version="1.0.39" />
-    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.15.0.24505">
+    <PackageReference Include="ImageSharpCompare" Version="1.1.30" />
+    <PackageReference Include="PdfjsSharp" Version="1.0.47" />
+    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.18.0.27296">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
@@ -28,10 +28,6 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="coverlet.collector" Version="1.3.0">
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-      <PrivateAssets>all</PrivateAssets>
-    </PackageReference>
   </ItemGroup>
 
   <ItemGroup>

PuppeteerSharp.RendererTests/ExpectedTestOutcome/ExpectedConvertHtmlToPngBasicTextFormated.html.png.diff.win.png

@@ -32,7 +32,7 @@ dotnet_csproj:
   patch: true
   file: '**\*.csproj'
   version: "{version}"
-  package_version: "{version}-prerelease"
+  package_version: "{version}"
   assembly_version: "{version}"
   file_version: "{version}"
   informational_version: "{version}"
@@ -47,7 +47,7 @@ artifacts:
 deploy:
   - provider: NuGet
     api_key:
-      secure: /G1AWAN6rAx8wnb36AM3XpYDyK9cVtfa3RdOsDYSw+Pxmy8AjztIGL7Zoo8nIikw
+      secure: CTISdGCfnpyC7Rh5vs1pgbuISrkWF34sot0SyVgvu0HQxhNNd+V0Gc4MS+rtJttB
     skip_symbols: false
     on:
       branch: main