Skip to content

Add game class and player interface #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 24 commits into
base: epic/play-against-computer
Choose a base branch
from

Conversation

aquino-a
Copy link
Contributor

@aquino-a aquino-a commented Mar 23, 2021

The purpose of this PR is to have game class that can be used for playing against a computer player.
The player interface will allow a human player and computer player to be implemented.

resolves #28

Alex and others added 22 commits March 17, 2021 11:00
 -receives card
 -calculates score and best score
 -test scoring
-update hand tests
-update calculate method with ace as special case with 11 points
-remove sonar smells
-use datapoints in hand test
-add exception documentation
-add tests for null cards
-rank display style

Co-authored-by: Stephan van Hulst <[email protected]>
make rank points variable final

Co-authored-by: Stephan van Hulst <[email protected]>
-make the cards variable final

Co-authored-by: Stephan van Hulst <[email protected]>
-remove MAX_SCORE_COUNT
-remove cached scores and best score
-fix checkstyle violations
-remove html
-add parameter validation
-update thrown exception in test
-refactor bestScore()
-add more hand test cases
@nibsi
Copy link
Member

nibsi commented Mar 23, 2021

Please reopen this PR when the other PRs have merged.

@nibsi nibsi closed this Mar 23, 2021
@nibsi nibsi reopened this Apr 1, 2021
@nibsi nibsi changed the base branch from master to epic/play-against-computer April 1, 2021 14:27
aquino-a and others added 2 commits April 2, 2021 09:18
…anchCorral/Blackjack into feature/game

� Conflicts:
�	core/src/main/java/com/coderanch/blackjack/Card.java
�	core/src/main/java/com/coderanch/blackjack/Hand.java
�	core/src/test/java/com/coderanch/blackjack/HandTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Game class and Player interface
2 participants