-
Notifications
You must be signed in to change notification settings - Fork 2
Add game class and player interface #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aquino-a
wants to merge
24
commits into
epic/play-against-computer
Choose a base branch
from
feature/game
base: epic/play-against-computer
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-receives card -calculates score and best score -test scoring
-update hand tests -update calculate method with ace as special case with 11 points
-use datapoints in hand test
-add exception documentation -add tests for null cards
-rank display style Co-authored-by: Stephan van Hulst <[email protected]>
make rank points variable final Co-authored-by: Stephan van Hulst <[email protected]>
-make the cards variable final Co-authored-by: Stephan van Hulst <[email protected]>
…into feature/hand
-fix checkstyle violations
-remove html -add parameter validation -update thrown exception in test
-refactor bestScore() -add more hand test cases
…into feature/game
Please reopen this PR when the other PRs have merged. |
…anchCorral/Blackjack into feature/game � Conflicts: � core/src/main/java/com/coderanch/blackjack/Card.java � core/src/main/java/com/coderanch/blackjack/Hand.java � core/src/test/java/com/coderanch/blackjack/HandTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to have game class that can be used for playing against a computer player.
The player interface will allow a human player and computer player to be implemented.
resolves #28