Skip to content

Conversation

mudit7777
Copy link
Collaborator

@mudit7777 mudit7777 commented Oct 16, 2025

Overview

Add Media Library icon

Screenshot 2025-10-17 at 2 59 36 PM

PR Checklist

  • Related to designs: Figma
  • Related to JIRA ticket: LXS-704
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to story X
  2. Do something
  3. Do that something in dark mode
  4. Check it with VO
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@mudit7777 mudit7777 requested a review from a team as a code owner October 16, 2025 20:49
@CLAassistant
Copy link

CLAassistant commented Oct 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mudit7777
❌ Mudit Arora


Mudit Arora seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nx-cloud
Copy link

nx-cloud bot commented Oct 16, 2025

View your CI Pipeline Execution ↗ for commit 72d5334


☁️ Nx Cloud last updated this comment at 2025-10-22 14:03:25 UTC

Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mudit!
The rendering of this icon looks off —
(This is what I see in light mode and dark mode)
Image

Image

One mistake I've seen others do is using the asset from Figma rather than Streamline, as mentioned in the docs: https://gamut.codecademy.com/?path=/docs/atoms-icons-about--docs

Could you double check this please? Thanks!
And a quick note about signing the CLA since this is an open source repo :)

Image

LMK if you have any Qs!

Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renders just fine now in light/dark mode! 🚀

@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@github-actions
Copy link
Contributor

@mudit7777 mudit7777 added the Ship It :shipit: Automerge this PR when possible label Oct 22, 2025
@codecademydev codecademydev merged commit 06e9161 into main Oct 22, 2025
20 of 22 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Oct 22, 2025
@codecademydev codecademydev deleted the add-media-library-icon-MA-LXS-704 branch October 22, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants