-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add media library icon - regular #3189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mudit Arora seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
View your CI Pipeline Execution ↗ for commit 72d5334 ☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mudit!
The rendering of this icon looks off —
(This is what I see in light mode and dark mode)

One mistake I've seen others do is using the asset from Figma rather than Streamline, as mentioned in the docs: https://gamut.codecademy.com/?path=/docs/atoms-icons-about--docs
Could you double check this please? Thanks!
And a quick note about signing the CLA since this is an open source repo :)

LMK if you have any Qs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renders just fine now in light/dark mode! 🚀
📬 Published Alpha Packages:
|
🚀 Styleguide deploy preview ready! Preview URL: https://68f8e4d2b5b8e7a8e8f22c15--gamut-preview.netlify.app |
Overview
Add Media Library icon
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs