Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] JavaScript DOM Manipulation: .querySelectorAll() #6296

Merged

Conversation

DimitrovErik
Copy link
Contributor

@DimitrovErik DimitrovErik commented Mar 6, 2025

Description

Issue Solved

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2025

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Mar 6, 2025
@mamtawardhani
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

please sign the CLA @DimitrovErik

@DimitrovErik
Copy link
Contributor Author

Thank you @mamtawardhani @CLAassistant for your message!
I have just signed the Contributor License Agreement, and I appreciate you looking into the status.
Please let me know if there's anything further needed from my side.🙌🏼

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DimitrovErik, thank you for contributing to Codecademy Docs, the entry is nicely written! 😄

I've suggested a few changes, could you please review and modify those at your earliest convenience? Thank you! 😃

DimitrovErik and others added 10 commits March 7, 2025 11:45
…orall/queryselectorall.md

Co-authored-by: Mamta Wardhani <[email protected]>
…orall/queryselectorall.md

Co-authored-by: Mamta Wardhani <[email protected]>
…orall/queryselectorall.md

Co-authored-by: Mamta Wardhani <[email protected]>
…orall/queryselectorall.md

Co-authored-by: Mamta Wardhani <[email protected]>
…orall/queryselectorall.md

Co-authored-by: Mamta Wardhani <[email protected]>
…orall/queryselectorall.md

Co-authored-by: Mamta Wardhani <[email protected]>
…orall/queryselectorall.md

Co-authored-by: Mamta Wardhani <[email protected]>
…orall/queryselectorall.md

Co-authored-by: Mamta Wardhani <[email protected]>
@DimitrovErik
Copy link
Contributor Author

Hey @mamtawardhani
I’ve addressed all the feedback. Let me know if further adjustments are required.
Thank you for your detailed commit suggestions 🙌🏼 – I really appreciate the guidance, and I’ve learned a lot from your feedback!

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @DimitrovErik 😄
The entry looks good for a second round of review! 🚀

@DimitrovErik
Copy link
Contributor Author

DimitrovErik commented Mar 8, 2025

@mamtawardhani
I just fix the formatting issue:
I ran Prettier to automatically fix formatting issues that were causing the format:verify check to fail.
The changes were committed, and the file is now properly formatted according to our Prettier configuration.
The following command was used to resolve the issue:
npx prettier --write
Everything should be good now, and the formatting has been verified🙌🏼🙃

@Sriparno08 Sriparno08 self-assigned this Mar 10, 2025
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Mar 10, 2025
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @DimitrovErik!

@Sriparno08 Sriparno08 merged commit ec410ba into Codecademy:main Mar 12, 2025
7 checks passed
Copy link

👋 @DimitrovErik
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/javascript/dom-manipulation/querySelectorAll

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Mar 12, 2025
@DimitrovErik
Copy link
Contributor Author

Appreciate you @Sriparno08 and @mamtawardhani for making those changes and merging them 🙌🏼!
Learned a lot, and really helped move things forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] JavaScript DOM Manipulation: .querySelectorAll()
4 participants