Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit, description and example of setAttribute() #6280

Merged
merged 11 commits into from
Mar 18, 2025

Conversation

punkphloyd
Copy link
Contributor

Description

Added the file setattribute.md describing the javascript method setAttribute(). Found in directory /content/javascript/concepts/dom-manipulation/terms/setattribute/

This has been submitted as part of the git/github training course at codecademy, and to contribute overall to the docs github.

Issue Solved

Closes #6238

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • [/ ] All writings are my own.
  • [/ ] My entry follows the Codecademy Docs style guide.
  • [/ ] My changes generate no new warnings.
  • [/ ] I have performed a self-review of my own writing and code.
  • [/ ] I have checked my entry and corrected any misspellings.
  • [/ ] I have made corresponding changes to the documentation if needed.
  • [/] I have confirmed my changes are not being pushed from my forked main branch.
  • [/ ] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [/ ] I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2025

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Mar 6, 2025
@mamtawardhani mamtawardhani added javascript JavaScript entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Mar 6, 2025
@mamtawardhani
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @punkphloyd please sign the CLA

@punkphloyd
Copy link
Contributor Author

Done - thanks @mamtawardhani :)

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @punkphloyd, thank you for contributing to Codecademy Docs, the entry is nicely written! 😄

I've suggested a few changes, could you please review and modify those at your earliest convenience? Thank you! 😃

```pseudo
setAttribute(name, value);
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define the parameters here in the format:

  • name:
  • value:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this and pushed it from my local clone to my remote github repo.
I can't see how to incorporate it into a pull request without generating a new one - apologies! Could you please advise?
Thanks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @punkphloyd you will have to be on the sam branch and commit and push the changes, that way it will get pushed in this PR itself

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a second round of review 🚀

Hey @punkphloyd for now I added the descriptions, so no need to push the changes again 😄

```pseudo
setAttribute(name, value);
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @punkphloyd you will have to be on the sam branch and commit and push the changes, that way it will get pushed in this PR itself

Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @punkphloyd!

@Sriparno08 Sriparno08 merged commit 3c3d351 into Codecademy:main Mar 18, 2025
7 checks passed
Copy link

👋 @punkphloyd
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/javascript/dom-manipulation/setAttribute

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] JavaScript DOM Manipulation: .setAttribute()
4 participants