-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit, description and example of setAttribute() #6280
Initial commit, description and example of setAttribute() #6280
Conversation
Hey @punkphloyd please sign the CLA |
Done - thanks @mamtawardhani :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @punkphloyd, thank you for contributing to Codecademy Docs, the entry is nicely written! 😄
I've suggested a few changes, could you please review and modify those at your earliest convenience? Thank you! 😃
content/javascript/concepts/dom-manipulation/terms/setattribute/setattribute.md
Outdated
Show resolved
Hide resolved
```pseudo | ||
setAttribute(name, value); | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please define the parameters here in the format:
name
:value
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this and pushed it from my local clone to my remote github repo.
I can't see how to incorporate it into a pull request without generating a new one - apologies! Could you please advise?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @punkphloyd you will have to be on the sam branch and commit and push the changes, that way it will get pushed in this PR itself
…e/setattribute.md Co-authored-by: Mamta Wardhani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for a second round of review 🚀
Hey @punkphloyd for now I added the descriptions, so no need to push the changes again 😄
```pseudo | ||
setAttribute(name, value); | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @punkphloyd you will have to be on the sam branch and commit and push the changes, that way it will get pushed in this PR itself
…ript-dom-setattribute
…phloyd/docs into javascript-dom-setattribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @punkphloyd!
👋 @punkphloyd 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/javascript/dom-manipulation/setAttribute Please note it may take a little while for changes to become visible. |
Description
Added the file setattribute.md describing the javascript method setAttribute(). Found in directory
/content/javascript/concepts/dom-manipulation/terms/setattribute/
This has been submitted as part of the git/github training course at codecademy, and to contribute overall to the docs github.
Issue Solved
Closes #6238
Type of Change
Checklist
main
branch.Issues Solved
section.