Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] JavaScript DOM Manipulation: .querySelectorAll() #6239 #6277

Closed

Conversation

dejongbaba
Copy link

Description

Added a new entry on the .querySelectorAll() term under the DOM concept in JavaScript. Created a new file under content/javascript/concepts/dom-manipulation/terms/queryselectorall/queryselectorall.md. Added description, syntax and example on the .querySelectorAll() following the term entry template and style guide. This entry explains how to select multiple elements with a specific selector and manipulate each of them.

Issue Solved

Closes #6239

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ mamtawardhani
✅ dakshdeepHERE
❌ dejongbaba
You have signed the CLA already but the status is still pending? Let us recheck it.

@dakshdeepHERE dakshdeepHERE self-assigned this Mar 4, 2025
@dakshdeepHERE dakshdeepHERE added javascript JavaScript entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Mar 4, 2025
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few comments for @dejongbaba you to work on :) Tag me once u are done with them

@dejongbaba
Copy link
Author

I have few comments for @dejongbaba you to work on :) Tag me once u are done with them

Alright, thanks for the feedback

@dejongbaba
Copy link
Author

@dakshdeepHERE I've updated the document as requested

Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mamtawardhani
Copy link
Collaborator

Hey @dejongbaba @dakshdeepHERE, just noticed that this issue has already been taken care of by the author who was assigned to it, so we have an entry for this already. I'll have to close this PR.

@dejongbaba for future reference, please claim an issue first and once it has been assigned to you, then raise a PR. Thank you 😄

@mamtawardhani mamtawardhani added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] JavaScript DOM Manipulation: .querySelectorAll()
4 participants