Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] Sankey #6268

Merged
merged 15 commits into from
Mar 12, 2025
Merged

[Term Entry] Sankey #6268

merged 15 commits into from
Mar 12, 2025

Conversation

alessandrocapialbi
Copy link
Contributor

@alessandrocapialbi alessandrocapialbi commented Mar 2, 2025

Description

I have created a new term entry titled sankey.md adding a new directory named 'sankey'' under the terms directory in graph_objects concepts. This entry provides a comprehensive overview of the .Sankey() method in Plotly, which is used to generate Sankey diagrams.

Issue Solved

Closes #6251

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2025

CLA assistant check
All committers have signed the CLA.

@alessandrocapialbi alessandrocapialbi changed the title Sankey Term Entry [Term Entry] Sankey Mar 2, 2025
@dakshdeepHERE dakshdeepHERE self-assigned this Mar 3, 2025
@dakshdeepHERE dakshdeepHERE added new entry New entry or entries status: under review Issue or PR is currently being reviewed plotly Python:Plotly entries labels Mar 3, 2025
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the code snippet locally and the output remains the same so this works :) I only have few comments for you to work on let's fix them and move this PR for second review.

@alessandrocapialbi
Copy link
Contributor Author

Hi @dakshdeepHERE, I should have resolved all the problems. Let me know if there are any others.

Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes this looks good for second review

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessandrocapialbi The entry looks good to be merged 🚀

Thank you for contributing! 😄

@mamtawardhani mamtawardhani added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Mar 12, 2025
@mamtawardhani mamtawardhani merged commit 5944106 into Codecademy:main Mar 12, 2025
7 checks passed
Copy link

👋 @alessandrocapialbi
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/plotly/graph-objects/sankey

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Plotly - graph_objects: .Sankey()
4 participants