Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create polyfill for JavaScript #5838

Merged

Conversation

DanielAsare-ux
Copy link
Contributor

@DanielAsare-ux DanielAsare-ux commented Dec 18, 2024

This pull request adds a new documentation file that provides a polyfill for the Array.prototype.includes method in JavaScript. The documentation aims to help developers understand how to implement polyfills for older JavaScript environments that do not natively support certain methods.

Key changes:

  • content/javascript/concepts/methods/Polyfill/polyfill.md: Added a detailed guide on creating a polyfill for Array.prototype.includes. The guide includes an introduction to polyfills, the syntax for writing a polyfill, and an example implementation with an explanation.<!--
    👋 Hi, thanks for submitting a PR to Codecademy Docs! ❤️
    Please fill out all fields below to ensure your PR is reviewed quickly.

IMPORTANT

If you would like to receive credit for your contribution to an entry, make sure to have your Codecademy user profile linked to your GitHub account:

  1. Go to your Codecademy dashboard.
  2. Click on your profile image in the top-right and then choose "Profile.".
  3. Then click "Edit Profile.".
  4. In the "GitHub Username" field, add your username (without the @).
  5. Click "Save Changes."

Of course, you can opt not to do this and be listed as an "anonymous contributor" instead. :)
-->

Description

  • Added polyfill concept for JavaScript
  • Editing an existing entry (fixing a typo, bug, issues, etc.)

Issue Solved

#5803

Type of Change

  • Add a new entry
  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc.)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

@SaviDahegaonkar SaviDahegaonkar self-assigned this Dec 19, 2024
Copy link
Contributor

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DanielAsare-ux,
I reviewed your file, and the entry does not follow the style-guide documentation guidelines. Please refer to the documentation and make the changes as soon as possible.

Thanks,
Savi

@SaviDahegaonkar SaviDahegaonkar added the invalid This doesn't seem right; not eligible for Hacktoberfest label Jan 1, 2025
Copy link
Contributor Author

@DanielAsare-ux DanielAsare-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@SaviDahegaonkar
Copy link
Contributor

Hey @DanielAsare-ux ,
I hope you're doing well. Thanks for contributing to Codecademy Docs! However, we won't be able to accept or review this entry as it is missing a lot of key requirements for a doc entry as per our style guide, such as essential metadata and formatting. Additionally, the entry appears to be placed in the incorrect file path also it does not aligns with the issue linked to this PR. I am closing this PR for now, but feel free to make the required changes and raise a new PR.
Thanks,
Savi

@SaviDahegaonkar SaviDahegaonkar added javascript JavaScript entries new entry New entry or entries status: review 1️⃣ completed status: ready for next review and removed invalid This doesn't seem right; not eligible for Hacktoberfest labels Jan 21, 2025
@PragatiVerma18 PragatiVerma18 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jan 21, 2025
@PragatiVerma18 PragatiVerma18 self-assigned this Jan 21, 2025
Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DanielAsare-ux, the entry is now good to be merged! 🚀

@PragatiVerma18 PragatiVerma18 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 21, 2025
@PragatiVerma18 PragatiVerma18 merged commit a3e7f14 into Codecademy:main Jan 21, 2025
7 checks passed
Copy link

👋 @DanielAsare-ux
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/javascript/polyfill

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants