Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed Concept Entry for Javascript: Optional Chaining #5805 #5826

Merged
merged 17 commits into from
Dec 27, 2024

Conversation

nbarnhouse
Copy link
Contributor

Description

Added Optional Chaining concept entry to JavaScript.

Issue Solved

Type of Change

  • Adding a new entry

Checklist

  • [ x] All writings are my own.
  • [x ] My entry follows the Codecademy Docs style guide.
  • [ x] My changes generate no new warnings.
  • [x ] I have performed a self-review of my own writing and code.
  • [x ] I have checked my entry and corrected any misspellings.
  • [x ] I have made corresponding changes to the documentation if needed.
  • [x ] I have confirmed my changes are not being pushed from my forked main branch.
  • [x ] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x ] I have linked any issues that are relevant to this PR in the Issues Solved section.

Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nbarnhouse, thanks for contributing this entry, I have some suggestions that I have added as comments, please check them and do the required changes. Let me know if you need any help. Happy contributing! 🚀

Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nbarnhouse, this is good for a second review! 🚀

@mamtawardhani mamtawardhani added javascript JavaScript entries new entry New entry or entries status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Dec 26, 2024
@mamtawardhani mamtawardhani self-assigned this Dec 26, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @nbarnhouse 😄

The entry looks good to be merged! 🚀

@mamtawardhani mamtawardhani added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Dec 27, 2024
@mamtawardhani mamtawardhani merged commit 13a434d into Codecademy:main Dec 27, 2024
6 checks passed
Copy link

👋 @nbarnhouse
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/javascript/optional-chaining

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants