Skip to content

Conversation

MarkFarmiloe
Copy link
Contributor

@MarkFarmiloe MarkFarmiloe commented Oct 6, 2025

This is a:

  • New feature - new behaviour has been implemented
  • 🐛 Bug fix - existing behaviour has been made to behave
  • ♻️ Refactor - the behaviour has not changed, just the implementation
  • Test backfill - tests for existing behaviour were added but the behaviour itself hasn't changed
  • ⚙️ Chore - maintenance task, behaviour and implementation haven't changed

Description

form-data needs to be upgraded to ^4.0.4.
This cannot be done (safely) with react-scripts, so need to move to Vite, which is already in ADR0002 and Migrate client app from CRA to Vite
#850
.

  • Purpose
    Enhance security and future maintenance.
  • How to check -
    Run and test the form.

Links

Fix 'form-data uses unsafe random function' security vulnerability
#1102

Author checklist

  • I have written a title that reflects the relevant ticket
  • I have written a description that says what the PR does and how to validate it
  • I have linked to the project board ticket (and any related PRs/issues) in the Links section
  • I have added a link to this PR to the ticket
  • I have made the PR to qa from a branch named <category>/<name>, e.g. feature/edit-spaceships or bugfix/restore-oxygen
  • I have completed the manual tests described here
  • I have requested reviewers here and in my team chat channel
  • I have spoken with my PM or TL about any parts of this task that may have become out-of-scope, or any additional improvements that I now realise may benefit my project
  • I have added tests, or new tests were not required
  • I have updated any documentation (e.g. diagrams, schemas), or documentation updates were not required

Copy link

@mohsenkhosroanjam mohsenkhosroanjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected.

@mohsenkhosroanjam mohsenkhosroanjam moved this from 🧪 In testing (QA) to 💯 QA approved in Dashboard/ITD/Volunteer form Backlog Oct 9, 2025
@MarkFarmiloe MarkFarmiloe merged commit ed78b81 into staging Oct 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants