Skip to content

Conversation

@Fradoka
Copy link

@Fradoka Fradoka commented Jul 18, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Questions

@Fradoka Fradoka added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 18, 2025
@Fradoka Fradoka changed the title London | ITP-July-2025 | Franklin Kamela | Sprint 2 | jq exercises London | SDC-July-2025 | Franklin Kamela | Sprint 2 | jq exercises Jul 18, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm assuming you only want me to review what is in the jq directory - I think you may have accidentally committed other files as well.

Good work on the jq tasks - I only have a comment for task 2

jq/script-02.sh Outdated
# TODO: Write a command to output the address of the person, all on one line, with a comma between each line.
# Your output should be exactly the string "35 Fashion Street, London, E1 6PX", but should not contain any quote characters.
path="/Users/cyf/Documents/SDC/Module-Tools/jq/person.json"
jq -r '.address | "\(.[0]), \(.[1]), \(.[2])"' $path

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of a solution that would work if the address has more than 3 lines?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 11, 2025
@Fradoka Fradoka added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Aug 31, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants