Skip to content

Cape Town| 25-SDC-July | Faith Muzondo | Sprint 1 | Number systems #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Faithy4444 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cape Town| 25-SDC-July | Faith Muzondo | Sprint 1 | Number systems #83

Faithy4444 wants to merge 1 commit into from

Conversation

@Faithy4444
Copy link

@Faithy4444 Faithy4444 commented Jul 15, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Faithy4444 Faithy4444 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2025
@chinar-amrutkar chinar-amrutkar self-assigned this Jul 16, 2025
@chinar-amrutkar chinar-amrutkar added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 20, 2025
chinar-amrutkar
chinar-amrutkar reviewed Jul 20, 2025
View reviewed changes
Copy link

@chinar-amrutkar chinar-amrutkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. However, I can see you have included several different exercises in this PR. Please create a new PR which only includes the Number Systems exercise :)

@chinar-amrutkar chinar-amrutkar added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 20, 2025
@Faithy4444
Copy link
Author

Faithy4444 commented Jul 21, 2025

my apologies, I made another branch the parent branch by mistake. Fixed it now

chinar-amrutkar
chinar-amrutkar approved these changes Jul 22, 2025
View reviewed changes
Copy link

@chinar-amrutkar chinar-amrutkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done!

@chinar-amrutkar chinar-amrutkar removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 22, 2025
@illicitonion illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 13, 2025
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chinar-amrutkar chinar-amrutkar chinar-amrutkar approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@chinar-amrutkar chinar-amrutkar

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Faithy4444 @chinar-amrutkar @illicitonion