-
-
Notifications
You must be signed in to change notification settings - Fork 42
London| SDC-N0v-25| Ikenna Agulobi | Sprint 5| Laptop allocation #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| from dataclasses import dataclass | ||
| from enum import Enum | ||
| from typing import List, Dict, Optional, Tuple | ||
| import itertools | ||
| import sys | ||
|
|
||
| class OperatingSystem(Enum): | ||
| MACOS = "macOS" | ||
| ARCH = "Arch Linux" | ||
| UBUNTU = "Ubuntu" | ||
|
|
||
| @dataclass(frozen=True) | ||
| class Person: | ||
| name: str | ||
| age: int | ||
| preferred_operating_system: List[OperatingSystem] | ||
|
|
||
| # custom hash to hash the immutable version of the list | ||
| def __hash__(self) -> int: | ||
| return hash((self.name, self.age, tuple(self.preferred_operating_system))) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice! The non-hashability of List caught many people out (including me, initially - I'm more C# than Python). This is a nice workaround.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @OracPrime Thanks for reviewing my PR and for the feedback. I really appreciate it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was good code - you may notice I took the liberty of quoting it in the Nov SDC slack channel! |
||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class Laptop: | ||
| id: int | ||
| manufacturer: str | ||
| model: str | ||
| screen_size_in_inches: float | ||
| operating_system: OperatingSystem | ||
|
|
||
| # =====define parse operating system====== | ||
| def parse_operating_system(raw: str) -> OperatingSystem: | ||
| normalized = raw.strip().lower() | ||
|
||
|
|
||
| aliases = { | ||
| "macos": OperatingSystem.MACOS, | ||
| "mac": OperatingSystem.MACOS, | ||
| "arch": OperatingSystem.ARCH, | ||
| "arch linux": OperatingSystem.ARCH, | ||
| "ubuntu": OperatingSystem.UBUNTU, | ||
| } | ||
|
|
||
| if normalized not in aliases: | ||
| valid = ", ".join(sorted(aliases.keys())) | ||
| print(f"Error: invalid operating system. Try one of: {valid}", file=sys.stderr) | ||
|
||
| sys.exit(1) | ||
|
|
||
| return aliases[normalized] | ||
|
|
||
| # ======= sadness helper ============ | ||
| def sadness(person: Person, laptop: Laptop) -> int: | ||
| laptop_os = laptop.operating_system | ||
| preferences = person.preferred_operating_system | ||
| if laptop_os not in preferences: | ||
| return 100 | ||
| return preferences.index(laptop_os) | ||
|
|
||
| # ======= Laptop allocation ============ | ||
| def allocate_laptops(people: List[Person], laptops: List[Laptop]) -> Dict[Person, Laptop]: | ||
| if len(laptops) < len(people): | ||
| raise ValueError("Not enough laptops to allocate one per person.") | ||
|
|
||
| best_assignment: Optional[Dict[Person, Laptop]] = None | ||
| best_total_sadness: Optional[int] = None | ||
|
|
||
| for chosen_laptops in itertools.combinations(laptops, len(people)): | ||
|
||
| for permuted_laptops in itertools.permutations(chosen_laptops): | ||
| total = 0 | ||
| for i in range(len(people)): | ||
| person = people[i] | ||
| laptop = permuted_laptops[i] | ||
| total += sadness(person, laptop) | ||
|
|
||
| if best_total_sadness is None or total < best_total_sadness: | ||
| best_total_sadness = total | ||
| best_assignment = {people[i]: permuted_laptops[i] for i in range(len(people))} | ||
|
|
||
| if best_assignment is None: | ||
| raise RuntimeError("Allocation failed unexpectedly.") | ||
|
|
||
| return best_assignment | ||
|
|
||
| # ======define main ================ | ||
| def main() -> None: | ||
| laptops = [ | ||
| Laptop(id=1, manufacturer="Dell", model="XPS", screen_size_in_inches=13.0, operating_system=OperatingSystem.ARCH), | ||
| Laptop(id=2, manufacturer="Dell", model="XPS", screen_size_in_inches=15.0, operating_system=OperatingSystem.UBUNTU), | ||
| Laptop(id=3, manufacturer="Dell", model="XPS", screen_size_in_inches=15.0, operating_system=OperatingSystem.UBUNTU), | ||
| Laptop(id=4, manufacturer="Apple", model="macBook", screen_size_in_inches=13.0, operating_system=OperatingSystem.MACOS), | ||
| ] | ||
|
|
||
| people = [ | ||
| Person(name="Imran", age=22, preferred_operating_system=[OperatingSystem.UBUNTU, OperatingSystem.ARCH, OperatingSystem.MACOS]), | ||
| Person(name="Eliza", age=34, preferred_operating_system=[OperatingSystem.ARCH, OperatingSystem.UBUNTU]) | ||
| ] | ||
|
|
||
| allocation = allocate_laptops(people, laptops) | ||
|
|
||
| # Print results | ||
| for person, laptop in allocation.items(): | ||
| print(f"{person.name}: Laptop {laptop.id} ({laptop.operating_system.value}) sadness={sadness(person, laptop)}") | ||
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect you started using a Tuple and changed it to a List? It's good practice to remove unwanted imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out. I've removed unwanted imports.