London|25-SDC-NOV| FATMA DEGIRMENCI | Sprint 4|Implement cowsay #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatmaevin
added
📅 Sprint 4
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Dec 23, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start. I have left some comments. Also, can you include a requirements file so I know which library you intend to use?
| if animal not in animals: | ||
| print(f"Invalid animal. Supported animals are: {', '.join(animals)}") | ||
| exit(1) | ||
| cowsay.char_funcs[animal](args.text) |
There was a problem hiding this comment.
What happens if I give my arguments as plain text, without quotes?
|
|
||
| parser = argparse.ArgumentParser(description="implement Cowsay command") | ||
| parser.add_argument("text", help="Text to be displayed") | ||
| parser.add_argument("--animal", help="Animal to say the text", default="cow") |
There was a problem hiding this comment.
Can you get the help to show the list of possible animals?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist