London | SDC-Nov-25 | Emiliano Uruena | Sprint 4 | Implement shell Tools Python #283
Conversation
Emilianouz
added
📅 Sprint 4
LonMcGregor
added
the
Review in progress
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
bot
removed
the
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on these tasks. They might be improved further if you consider my question about argument parsing
There was a problem hiding this comment.
Did you mean to make changes to this file? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the shell tools sprint task directory.
| print(f"cat: {filename}: No such file or directory", file=sys.stderr) | ||
|
|
||
| def main(): | ||
| args = sys.argv[1:] |
There was a problem hiding this comment.
Do you know of any easier ways to help build argument parsing? you can do it manually, but you are missing a help option, and adding more complex arguments might get complicated in larger scripts.
|
|
||
| elif flag == "-n": | ||
| for index, line in enumerate(file, start=1): | ||
| print(f"{index:6}\t{line}", end="") |
LonMcGregor
added
Reviewed
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 participants
Self checklist
Changelist
Implementing shell tools: cat, ls, and wc in python.