WestMidlands| SDC-NOV-2025| SARA TAHIR | Sprint 5 | Feature/Prep #282
Conversation
…All bugs have been resolved.
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
SaraTahir28
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
4 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
SaraTahir28
added
the
Needs Review
SaraTahir28
changed the title
OracPrime
added
the
Review in progress
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
Good code here. Only one bug (and that's only a bug if you allow accounts to have negative balances, but probably worth fixing, since that happens in the real world)
|
|
||
| print(is_adult(imran)) | ||
|
|
||
| def works_at(person: Person) -> str: |
There was a problem hiding this comment.
Not sure what works_at is doing here?
| num = double("22") | ||
| print(num) | ||
|
|
||
| #my prediction is that it would return 2222. As python will treat 22 as a string being a strongly typed language. |
There was a problem hiding this comment.
Technically Python is "duck typed" not "strongly typed" - worth googling the difference.
| try: | ||
| age = int(age_str) | ||
| except ValueError: | ||
| print("Error: Age must be a number.", file= sys.stderr) |
| for child in person.children: | ||
| print(f" {child.name} ({child.age})") | ||
|
|
||
| print_family_tree(Sara) No newline at end of file |
There was a problem hiding this comment.
This is all good. If you want (and only if you want) a stretch objective, make it cope with children who have children and print out a proper tree (so children, grandchildren, great-grandchildren increasingly indented). Definitely an optional task
|
|
||
| for person in people: | ||
| possible_laptops = find_possible_laptops(laptops, person) | ||
| print(f"Possible laptops for {person.name}: {possible_laptops}") No newline at end of file |
|
|
||
| def format_pence_as_string(total_pence: int)-> str: #type int returns type str | ||
| #formatting pence as a string | ||
| if total_pence < 100: |
There was a problem hiding this comment.
What happens if the account has a negative balance?
OracPrime
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
Completed all exercises in seperate files in the prep.
Questions
Please give me feedback on my work. Thanks