Skip to content

Conversation

@delmorallopez
Copy link

Implement Cowsay Library in Python

Write a command line tool which uses the cowsay library to show user-supplied text, as said by a specified animal.

Used the cowsay library, and not write down the list of supported animals yourself, just fetch this information from the library.

@delmorallopez delmorallopez added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 3, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Dec 23, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Some feedback:

  • It is generally not a good idea to be reading library files directly like this. What if the library updates and changes where they are stored?
  • You are missing a requirements file, so I can't run this unless I already know which library needs to be installed

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Dec 23, 2025
@delmorallopez
Copy link
Author

I’ve updated the script to use the cowsay public API instead of reading library files, and added a requirements.txt so the project is reproducible.

@delmorallopez delmorallopez force-pushed the implement-cowsay branch 2 times, most recently from f53e7d9 to 2a2c485 Compare January 5, 2026 17:07
@delmorallopez delmorallopez added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 5, 2026
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, this is almost complete. When you run it, do you see it printing the message "None" after the output is finished? can you figure out why that is happening and remove it?

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 6, 2026
@delmorallopez
Copy link
Author

animal_func(message) prints the cow/turtle, It returns None
print(None) prints None at the end

SOLUTION: animal_func(message)

@delmorallopez delmorallopez added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 7, 2026
@LonMcGregor
Copy link

Great work, this task is complete now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants