-
-
Notifications
You must be signed in to change notification settings - Fork 42
London | 25-SDC-Nov | Jesus del Moral | Sprint 4 | Implement cowsay in Python #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
234f0a9 to
8eec635
Compare
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. Some feedback:
- It is generally not a good idea to be reading library files directly like this. What if the library updates and changes where they are stored?
- You are missing a requirements file, so I can't run this unless I already know which library needs to be installed
|
I’ve updated the script to use the cowsay public API instead of reading library files, and added a requirements.txt so the project is reproducible. |
f53e7d9 to
2a2c485
Compare
2a2c485 to
70d3155
Compare
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, this is almost complete. When you run it, do you see it printing the message "None" after the output is finished? can you figure out why that is happening and remove it?
|
animal_func(message) prints the cow/turtle, It returns None SOLUTION: animal_func(message) |
|
Great work, this task is complete now |
Implement Cowsay Library in Python
Write a command line tool which uses the cowsay library to show user-supplied text, as said by a specified animal.
Used the cowsay library, and not write down the list of supported animals yourself, just fetch this information from the library.