Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 4 | Implement cowsay in Python #273
Conversation
RahwaZeslusHaile
added
the
Needs Review
LonMcGregor
added
the
Review in progress
|
I think you have 2PRs here. Could you close one and let me know which one you want reviewed? |
LonMcGregor
added
Reviewed
|
@LonMcGregor, sorry for the confusion. I’ve closed the other PR to avoid confusion and ensure all feedback is focused on this one. This is the PR I would like you to review. Thank you! |
RahwaZeslusHaile
added
the
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this task, I've left some pointers
| @@ -1 +1,2 @@ | |||
| node_modules | |||
| .venv | |||
There was a problem hiding this comment.
Correct, you want to exclude the .venv directory. But what about the things you are installing into the .venv. Is there enough comitted here for me to be able to re-create your venv on my machine? which file is missing?
| text = " ".join(args.message) | ||
| animal = args.animal | ||
|
|
||
| supported_animals = [ |
There was a problem hiding this comment.
Part of the task spec is finding a way to write this without you having to declare this array yourself. can you figure out how to get the animals directly from the library?
LonMcGregor
removed
the
Needs Review
2 participants
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 4 | Implement cowsay in Python
Learners, PR Template
Self checklist
Changelist
Mimics the basic behavior of the cowsay command line tool in Python.
Supports a message input and optional --animal selection.
Shows an error for unsupported animals, similar to the official CLI.
Questions
The implementation currently mimics the official cowsay CLI by showing an error when an unsupported animal is provided, using a hardcoded list of animals. Is this approach acceptable, or would you recommend a different method for handling unsupported animals? Thank you!