Skip to content

Conversation

@RahwaZeslusHaile
Copy link

Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 4 | Implement shell tools (cat, ls, wc) in Python

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  This PR adds Python implementations of basic shell tools:
  myls.py – lists directory contents, supports -a and -1.
  mycat.py – prints file contents, supports -n and -b.
  mywc.py – counts lines, words, characters, supports multiple files and -l, -w, -c.

Questions

Thank you for your time reviewing this work

@RahwaZeslusHaile RahwaZeslusHaile added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 1, 2025
@OracPrime OracPrime added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Dec 29, 2025
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is good, well done. If I wanted to get picky, I say that you should be outputting any error messages to stderr not stdout - you should be able to find do different ways of doing this in Python. However just consider that for future work - I'll flag this as complete as is.

@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 29, 2025
@RahwaZeslusHaile
Copy link
Author

Thank you @OracPrime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants